New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835967 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 829541



Sign in to add a comment

mac_optional_gpu_tests_rel is broken again

Project Member Reported by roc...@chromium.org, Apr 23 2018

Issue description

It seems this was broken late last week and recovered over the weekend. It's broken again now and difficult to get CLs to pass through.

Random sampling of the failed builds shows consistently that gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_attribs_gl_bindAttribLocation_aliasing_inactive is failing with:

====

gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_attribs_gl_bindAttribLocation_aliasing_inactive failed unexpectedly 1.6487s:
  
  Traceback (most recent call last):
    _RunGpuTest at content/test/gpu/gpu_tests/gpu_integration_test.py:132
      self.RunActualGpuTest(url, *args)
    RunActualGpuTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:188
      getattr(self, test_name)(test_path, *args[1:])
    _RunConformanceTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:202
      self._CheckTestCompletion()
    _CheckTestCompletion at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:198
      self.fail(self._WebGLTestMessages(self.tab))
    fail at .swarming_module/lib/python2.7/unittest/case.py:410
      raise self.failureException(msg)
  AssertionError: Link should fail when both attributes are aliased to location 0
  FAIL Link should fail when both attributes are aliased to location 0
  Link should fail when both attributes are aliased to location 1
  FAIL Link should fail when both attributes are aliased to location 1
  Link should fail when both attributes are aliased to location 2
  FAIL Link should fail when both attributes are aliased to location 2
  Link should fail when both attributes are aliased to location 3
  FAIL Link should fail when both attributes are aliased to location 3
  Link should fail when both attributes are aliased to location 4
  FAIL Link should fail when both attributes are aliased to location 4
  Link should fail when both attributes are aliased to location 5
  FAIL Link should fail when both attributes are aliased to location 5
  Link should fail when both attributes are aliased to location 6
  FAIL Link should fail when both attributes are aliased to location 6

  ...etc...


The first failure occurred after this skia roll: https://chromium-review.googlesource.com/c/chromium/src/+/1024271
 
 Issue 835969  has been merged into this issue.
Labels: -Pri-3 Pri-1
P1 since this is blocking CQ. Also, that particular skia roll link points to an abandoned roll.
Cc: kainino@chromium.org
I think this is due to r552732. Reverting.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f1a9f45a403f03ce0b66b5bc21862297868024

commit 19f1a9f45a403f03ce0b66b5bc21862297868024
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Apr 23 20:59:02 2018

Revert "remove webgl suppression for gl-bindAttribLocation-aliasing-inactive.html"

This reverts commit 4c002763faf7041f2021be79b86e5e8e85022cb2.

Reason for revert: Causing CQ failures.

Original change's description:
> remove webgl suppression for gl-bindAttribLocation-aliasing-inactive.html
> 
> TBR=kbr@chromium.org
> 
> Bug:  829541 
> Change-Id: I6b6e481ec11abf895debe2cf3cfe44e812b2b436
> Reviewed-on: https://chromium-review.googlesource.com/1023715
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552732}

TBR=kainino@chromium.org

Change-Id: Id155fd5d4d80143a8880ce6a53b7d993da4bab4c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829541 ,  835967 
Reviewed-on: https://chromium-review.googlesource.com/1024718
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552825}
[modify] https://crrev.com/19f1a9f45a403f03ce0b66b5bc21862297868024/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Status: fixe (was: Untriaged)
Sorry all. I messed up removing the submission and the 
Owner: thestig@chromium.org
Status: Fixed (was: Fixe)
Cq-Include-Trybots line was missing. Thanks Lei for handling it!

Comment 7 by kbr@chromium.org, Apr 27 2018

Blocking: 829541

Sign in to add a comment