DynamicsCompressorNode channelCountMode incorrect |
|
Issue descriptionTry the following in the dev console c = new AudioContext() n = new DynamicsCompressorNode(c) n.channelCountMode The initial channelCountMode should be "clamped-max": https://webaudio.github.io/web-audio-api/#dynamicscompressornode
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a69dd6c593843cde1124c0cee5bfad9d298f4d4 commit 6a69dd6c593843cde1124c0cee5bfad9d298f4d4 Author: Raymond Toy <rtoy@chromium.org> Date: Tue Apr 24 20:34:22 2018 DynamicsCompressor.channelCountMode is 'clamped-max' As mentioned in the spec (https://webaudio.github.io/web-audio-api/#dynamicscompressornode), the channelCountMode defaults to "clamped-max", not "max". Make it so. Bug: 835946 Test: webaudio/constructor/dynamicscompressor.html Change-Id: I8aee3336a89ff5662ecbe7afee1793cb94184169 Reviewed-on: https://chromium-review.googlesource.com/1024791 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553252} [modify] https://crrev.com/6a69dd6c593843cde1124c0cee5bfad9d298f4d4/third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html [modify] https://crrev.com/6a69dd6c593843cde1124c0cee5bfad9d298f4d4/third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.cc |
|
►
Sign in to add a comment |
|
Comment 1 by rtoy@chromium.org
, Apr 23 2018Status: Assigned (was: Unconfirmed)