Tablet mode mobile-like "shrink to fit" should not be applied to Chrome OS internal pages |
||||||
Issue descriptionPages such as settings, bookmarks, ... etc. shouldn't have the "shrink to fit" webkit preference turned on for them.
,
Apr 26 2018
,
Apr 30 2018
,
Apr 30 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2018
Has there been testing to confirm the fix with no ill effects? Is this originating from a M67 regression, feature, or older issue?
,
May 1 2018
This is a feature that was implemented in M-67 without the exclusions made by this CL being taken into account. There has been testing, and the CL itself include browser tests.
,
May 1 2018
Thanks for the quick update. I assume that feature was included in the regular feature reviews?
,
May 1 2018
Hi there, UI review thread on this feature with a specific section about this change and approval: https://groups.google.com/a/google.com/forum/#!topic/chromeos-ui-review/BP3kwlL0yzg Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=822453
,
May 2 2018
This feature was approved for M68, not M67.
,
May 2 2018
The shrink to fit issue that this CL is fixing landed in M-67. We need to merge the fix back.
,
May 3 2018
Reviewed with afakhry@. Approving since there has been testing and it's a M67 regression. Approving merge to M67 Chrome OS.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2d2ad192b6a9417b19acf3e00daeea288451061 commit d2d2ad192b6a9417b19acf3e00daeea288451061 Author: Ahmed Fakhry <afakhry@google.com> Date: Thu May 03 20:48:03 2018 [Merge to M67] Tablet mode page mobile-like behavior exclusions This CL excludes the mobile-like page bahvior Webkit prefs from being set in tablet mode for: - Hosted apps in browsers (V1 apps and PWAs) - Internal pages such as chrome://settings - New Tab Pages. TBR=xiyuan@chromium.org BUG=822455, 835939 TEST=Added new test. (cherry picked from commit 549fb56aa764e43c5a6adcaaacb95dea6a242a46) Change-Id: I07592d511e78092e0f66959463aa456f7177efb0 Reviewed-on: https://chromium-review.googlesource.com/1030899 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554137} Reviewed-on: https://chromium-review.googlesource.com/1043067 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#466} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/d2d2ad192b6a9417b19acf3e00daeea288451061/chrome/browser/chromeos/chrome_content_browser_client_chromeos_part.cc [modify] https://crrev.com/d2d2ad192b6a9417b19acf3e00daeea288451061/chrome/browser/ui/ash/tablet_mode_page_behavior_browsertest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 26 2018