New issue
Advanced search Search tips

Issue 835936 link

Starred by 3 users
Status: Assigned
Owner:
mxnguyen@chromium.org
Cc:
waff...@chromium.org
proberge@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Verify that the NewExtensionUpdater uses the installsource and installedby parameters

Project Member Reported by proberge@chromium.org, Apr 23 2018 
In ManifestFetchData::AddExtension (and a few other code locations), several parameters are added to extension download/update requests.

Namely, the "installsource" and "installedby" parameters are useful to keep track of how extensions are installed in Chrome.

@mxnguyen is working on a feature (NewExtensionUpdater) which moves some of the extension downloading/updating logic to the component updater.

We should make sure that, with this new feature enabled, the "installsource" and "installedby" parameters are still reported.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc16497ea2ff2d60576f76118fa14136f42d068a

commit fc16497ea2ff2d60576f76118fa14136f42d068a
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Tue Apr 24 16:05:35 2018

[update_client] Add installedby (extension manifest location) to update check requests.

Bug: 722942,  727861 , 835936
Change-Id: I256f5b1c54143a0c4ec5dccea668eb669673cc3d
Reviewed-on: https://chromium-review.googlesource.com/1025073
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553145}
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/components/update_client/protocol_builder.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/components/update_client/update_client.h
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/fc16497ea2ff2d60576f76118fa14136f42d068a/extensions/browser/updater/update_data_provider_unittest.cc

Comment 2 by karandeepb@chromium.org, Apr 27 2018

Status: Assigned (was: Untriaged)
[Extensions Triage] Marking as assigned.

Comment 3 by mxnguyen@chromium.org, May 7 2018 

Fixed.
►

Sign in to add a comment