New issue
Advanced search Search tips

Issue 835928 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

FileReader should synchronously kill its loader in abort()

Project Member Reported by mek@chromium.org, Apr 23 2018

Issue description

Currently the loader is destroyed asynchronously, but that means a load started immediately after abort() was called won't work, as that load will be terminated. We should fix that.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c75fd3d1679f09efb95ea486cb26f3d13431b92

commit 6c75fd3d1679f09efb95ea486cb26f3d13431b92
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Apr 24 18:20:06 2018

[FileAPI] Synchronously terminate loader when abort is called().

Otherwise loads started right after calling abort() won't work.

Also simplify the watching logic in MojoBlobReader, to prevent hitting
DCHECKs in OnResponseBodyStreamReady.

Bug:  835928 
Change-Id: I45eec517ccaf5f830101b6a02fce2fdcf696d17b
Reviewed-on: https://chromium-review.googlesource.com/1024315
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553204}
[modify] https://crrev.com/6c75fd3d1679f09efb95ea486cb26f3d13431b92/storage/browser/blob/mojo_blob_reader.cc
[modify] https://crrev.com/6c75fd3d1679f09efb95ea486cb26f3d13431b92/third_party/WebKit/LayoutTests/external/wpt/FileAPI/reading-data-section/FileReader-multiple-reads.html
[modify] https://crrev.com/6c75fd3d1679f09efb95ea486cb26f3d13431b92/third_party/blink/renderer/core/fileapi/file_reader.cc

Comment 2 by mek@chromium.org, Apr 24 2018

Status: Fixed (was: Started)
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI

Sign in to add a comment