New issue
Advanced search Search tips

Issue 835925 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cros splitscreen - occasional crash when shutting down

Project Member Reported by x...@chromium.org, Apr 23 2018

Issue description

Chrome Version: 68.0.3405.0
OS: Chrome

It's hard to reproduce this issue. Only happens occasionally. So the following steps doesn't always repro this issue. 

What steps will reproduce the problem?
(1) Enter tablet mode and then overview mode
(2) Drag two windows to snap to both sides of the screen
(3) Tap on the overview button and open overview grid on one side of the screen
(4) Close Chrome

What is the expected result?
No crash should be observed.

What happens instead?
Chrome crashes, see callstack:
[21181:21181:0423/110925.093811:FATAL:coordinate_conversion.cc(17)] Check failed: window. 
#0 0x7f67a0af35dc base::debug::StackTrace::StackTrace()
#1 0x7f67a0a3b27b logging::LogMessage::~LogMessage()
#2 0x7f679a23607b wm::ConvertPointToScreen()
#3 0x7f679a236299 wm::ConvertRectToScreen()
#4 0x7f679a9bb642 ash::ScopedTransformOverviewWindow::GetTargetBoundsInScreen()
#5 0x7f679a9be1b9 ash::WindowGrid::FitWindowRectsInBounds()
#6 0x7f679a9bddce ash::WindowGrid::PositionWindows()
#7 0x7f679a9bf4d1 ash::WindowGrid::SetBoundsAndUpdatePositions()
#8 0x7f679a9c30cb ash::WindowSelector::OnDisplayBoundsChanged()
#9 0x7f679a9c3844 ash::WindowSelector::OnSplitViewStateChanged()
#10 0x7f679a9d76eb ash::SplitViewController::UpdateSplitViewStateAndNotifyObservers()
#11 0x7f679a9d63de ash::SplitViewController::EndSplitView()
#12 0x7f679a9d9b96 ash::SplitViewController::OnSnappedWindowMinimizedOrDestroyed()
#13 0x7f679a9d995a ash::SplitViewController::OnWindowDestroying()
#14 0x7f679c372fd5 aura::Window::~Window()
#15 0x7f679c37374e aura::Window::~Window()
#16 0x7f679af886c7 _ZN4base8internal7InvokerINS0_9BindStateIMN5views12MouseWatcher8ObserverEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#17 0x7f67a0a1d665 base::debug::TaskAnnotator::RunTask()
#18 0x7f67a0a47689 base::internal::IncomingTaskQueue::RunTask()
#19 0x7f67a0a4ab7b base::MessageLoop::RunTask()
#20 0x7f67a0a4af0a base::MessageLoop::DeferOrRunPendingTask()
#21 0x7f67a0a4b16c base::MessageLoop::DoWork()
#22 0x7f67a0b08739 base::MessagePumpLibevent::Run()
#23 0x7f67a0a4a564 base::MessageLoop::Run()
#24 0x7f67a0a7cd59 base::RunLoop::Run()
#25 0x556a5e3c54a7 ChromeBrowserMainParts::MainMessageLoopRun()
#26 0x7f679dc166a7 content::BrowserMainLoop::RunMainMessageLoopParts()
#27 0x7f679dc194c6 content::BrowserMainRunnerImpl::Run()
#28 0x7f679dc12af9 content::BrowserMain()
#29 0x7f679e5f240d content::ContentMainRunnerImpl::Run()
#30 0x7f67a0f642b2 service_manager::Main()
#31 0x7f679e5f0084 content::ContentMain()
#32 0x556a5d8542c3 ChromeMain
#33 0x7f679336a2b1 __libc_start_main
#34 0x556a5d85413a _start

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbb07358ba8ab9694fa73e4a691812912df044d

commit 0dbb07358ba8ab9694fa73e4a691812912df044d
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Jun 08 17:07:47 2018

Cros splitscreen: Fix crash during shutdown when splitscreen is active.

The reason for this crash is when a window is destroying, it's still
regarded as an "activatable" window in MRU window list and is then
put in overview by SplitViewController::OnWindowDestroying(), which
will then cause crash when trying to adjust its bounds in overview.
(Currently the crash is only observed on Chrome built on linux
workstation, not reproducable on real devices)

To fix this, we observe OnWindowDestroyed() instead of
OnWindowDestroying() in SplitViewController.

Bug:  835925 
Change-Id: Ieda91eb3f8ab12e2120365b0804a30aeef8d8f2f
Reviewed-on: https://chromium-review.googlesource.com/1091534
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565662}
[modify] https://crrev.com/0dbb07358ba8ab9694fa73e4a691812912df044d/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/0dbb07358ba8ab9694fa73e4a691812912df044d/ash/wm/splitview/split_view_controller.h

Comment 2 by x...@chromium.org, Jun 8 2018

Status: Fixed (was: Assigned)

Sign in to add a comment