New issue
Advanced search Search tips

Issue 835924 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

PDF XFA: Text edit: Text renders with wrong offsets after deletion

Project Member Reported by hnakashima@chromium.org, Apr 23 2018

Issue description

On an XFA enabled build:

1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf
2. Under "PERSONAL DETAILS" "1. Full name" "* Family name", type "Nakashima".
3. Press Left on the keyboard 3 times to move the caret between the 'h' and the 'i'.
4. Press Backspace on the keyboard.
Expected: 'h' is deleted
Actual: 'h' is deleted and the characters after it now overlap with each other. See screenshot.
 
bug835924.png
8.7 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/df96bf69f22d63a0ab6c5e48556682b0532c3079

commit df96bf69f22d63a0ab6c5e48556682b0532c3079
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Apr 24 17:55:08 2018

Fix edit text rendered with wrong offsets after deletion.

Bug:  chromium:835924 
Change-Id: I3d6a3d1947cb1b8cda246cc74ef0b79a482b7997
Reviewed-on: https://pdfium-review.googlesource.com/31276
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/df96bf69f22d63a0ab6c5e48556682b0532c3079/xfa/fde/cfde_texteditengine.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912dea659fa5a798c0bcf244c5fc7ad2e31da270

commit 912dea659fa5a798c0bcf244c5fc7ad2e31da270
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 24 20:34:53 2018

Roll src/third_party/pdfium/ 90e03b9b3..6453a67d8 (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/90e03b9b3f45..6453a67d84dc

$ git log 90e03b9b3..6453a67d8 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 dsinclair Remove CFX_BlockBuffer
2018-04-24 hnakashima Fix edit text rendered with wrong offsets after deletion.
2018-04-24 dsinclair Cleanup CFX_XMLParser entity conversion
2018-04-24 hnakashima Fix caret moving to next line on click in multiline XFA edit.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:835924 , chromium:832293 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3b1032022230598dcb53c04384247169802053c9
Reviewed-on: https://chromium-review.googlesource.com/1024605
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553253}
[modify] https://crrev.com/912dea659fa5a798c0bcf244c5fc7ad2e31da270/DEPS

Sign in to add a comment