New issue
Advanced search Search tips

Issue 835921 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Scheduler UKMs are not recorded

Project Member Reported by altimin@chromium.org, Apr 23 2018

Issue description

Sampled tasks are not recorded in the UKM.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd62e47f90cb35fb2ce8fa0313aa9a6b4da2dad2

commit fd62e47f90cb35fb2ce8fa0313aa9a6b4da2dad2
Author: Alexander Timin <altimin@chromium.org>
Date: Tue Apr 24 06:12:11 2018

[scheduler] Actually sample scheduler tasks in UKM

The actual call to sampling code was missing. Fix it.

R=fmeawad@chromium.org
BUG= 835921 

Change-Id: I6ecdfe078f5884d37975174c1ba696dcc7e2bbaf
Reviewed-on: https://chromium-review.googlesource.com/1024412
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553015}
[modify] https://crrev.com/fd62e47f90cb35fb2ce8fa0313aa9a6b4da2dad2/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/fd62e47f90cb35fb2ce8fa0313aa9a6b4da2dad2/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc

Labels: Merge-Request-67
Status: Fixed (was: Started)
We need this fix to get the data from 67 for further analysis. 

Comment 3 by gov...@chromium.org, Apr 26 2018

Pls add appropriate OSs label. Thank you.
Components: Blink>Scheduling
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 26 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Apr 26 2018

Before we approve merge to M67, please answer followings:

* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M67?

Please note M67 is already in Beta, so merge bar is very high. Thank you.
Yes. The change have been in Canary for a week.

Comment 8 by gov...@chromium.org, Apr 30 2018

Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comments #2 and #7. Pls merge ASAP. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, May 1 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87abfc89cb0c096196453c7a5ee08bf20d9c833b

commit 87abfc89cb0c096196453c7a5ee08bf20d9c833b
Author: Alexander Timin <altimin@chromium.org>
Date: Tue May 01 14:45:11 2018

[scheduler] Actually sample scheduler tasks in UKM

The actual call to sampling code was missing. Fix it.

R=fmeawad@chromium.org
TBR=altimin@chromium.org
BUG= 835921 

(cherry picked from commit fd62e47f90cb35fb2ce8fa0313aa9a6b4da2dad2)

Change-Id: I6ecdfe078f5884d37975174c1ba696dcc7e2bbaf
Reviewed-on: https://chromium-review.googlesource.com/1024412
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553015}
Reviewed-on: https://chromium-review.googlesource.com/1037146
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#406}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/87abfc89cb0c096196453c7a5ee08bf20d9c833b/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/87abfc89cb0c096196453c7a5ee08bf20d9c833b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc

Sign in to add a comment