Scheduler UKMs are not recorded |
||||||
Issue descriptionSampled tasks are not recorded in the UKM.
,
Apr 26 2018
We need this fix to get the data from 67 for further analysis.
,
Apr 26 2018
Pls add appropriate OSs label. Thank you.
,
Apr 26 2018
,
Apr 26 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
Before we approve merge to M67, please answer followings: * Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M67? Please note M67 is already in Beta, so merge bar is very high. Thank you.
,
Apr 30 2018
Yes. The change have been in Canary for a week.
,
Apr 30 2018
Approving merge to M67 branch 3396 based on comments #2 and #7. Pls merge ASAP. Thank you.
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87abfc89cb0c096196453c7a5ee08bf20d9c833b commit 87abfc89cb0c096196453c7a5ee08bf20d9c833b Author: Alexander Timin <altimin@chromium.org> Date: Tue May 01 14:45:11 2018 [scheduler] Actually sample scheduler tasks in UKM The actual call to sampling code was missing. Fix it. R=fmeawad@chromium.org TBR=altimin@chromium.org BUG= 835921 (cherry picked from commit fd62e47f90cb35fb2ce8fa0313aa9a6b4da2dad2) Change-Id: I6ecdfe078f5884d37975174c1ba696dcc7e2bbaf Reviewed-on: https://chromium-review.googlesource.com/1024412 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553015} Reviewed-on: https://chromium-review.googlesource.com/1037146 Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#406} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/87abfc89cb0c096196453c7a5ee08bf20d9c833b/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/87abfc89cb0c096196453c7a5ee08bf20d9c833b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 24 2018