New issue
Advanced search Search tips

Issue 835904 link

Starred by 3 users
Status: Fixed
Owner:
agawronska@chromium.org
Closed: Jun 2018
Cc:
r...@chromium.org
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Demo mode] UMA for offline demo-mode?

Project Member Reported by mukai@chromium.org, Apr 23 2018 
crrev.com/c/1000012 adds a new enrollment mode, MODE_OFFLINE_DEMO for the offline demo mode.

chrome/browser/chromeos/login/enrollment_uma.cc is taking care of the UMA histogram for all enrollment modes, including this offline demo. It's unclear what's the expected behavior, since the offline demo mode should be done completely offline so there's no chances to send any metrics in that mode. But this function or someone else might want to consider sending the metrics of the offline demo mode when it becomes online?
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3f30d15de2f69b389142af006dc83f6d0c9f316

commit e3f30d15de2f69b389142af006dc83f6d0c9f316
Author: Jun Mukai <mukai@google.com>
Date: Thu Jun 21 20:29:35 2018

fix enrollment UMA

Noticed that the enrollment UMA will be invoked through the
enrollment flow for offline demo mode. At least it shouldn't be
NOTREACHED(). Considering the situation, I believe it can be
handled as other normal enrollment.

BUG= 835904 
TEST=manually

Change-Id: I61d50258429f3c72132c29d58a6208736756e3d8
Reviewed-on: https://chromium-review.googlesource.com/1092092
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569374}
[modify] https://crrev.com/e3f30d15de2f69b389142af006dc83f6d0c9f316/chrome/browser/chromeos/login/enrollment/enrollment_uma.cc

Comment 2 by mukai@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment