New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835903 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: content quad shouldn't be transparent when autofill is shown

Project Member Reported by asimjour@chromium.org, Apr 23 2018

Issue description

Autofill shouldn't change the transparency of the main content.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da685387eb4ec950ef5de8d02079673d14ba81a

commit 3da685387eb4ec950ef5de8d02079673d14ba81a
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Mon Apr 23 19:20:23 2018

VR: Autofill - Remove transparency of the web content

Autofill shouldn't make the content quad transparent.

Bug:  835903 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I33a3dcd02c526a24beccd3d5504fc26840e734fa
Reviewed-on: https://chromium-review.googlesource.com/1024283
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552787}
[modify] https://crrev.com/3da685387eb4ec950ef5de8d02079673d14ba81a/chrome/browser/vr/ui_scene_creator.cc

Labels: -M67 Merge-Request-67 M-67 Hotlist-VRB-MVP OS-Android
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3046a67c2fc15041957df0e39e66b5d4892bcf44

commit 3046a67c2fc15041957df0e39e66b5d4892bcf44
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Wed Apr 25 15:21:56 2018

VR: Autofill - Remove transparency of the web content

Autofill shouldn't make the content quad transparent.

Bug:  835903 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I33a3dcd02c526a24beccd3d5504fc26840e734fa
Reviewed-on: https://chromium-review.googlesource.com/1024283
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552787}(cherry picked from commit 3da685387eb4ec950ef5de8d02079673d14ba81a)
Reviewed-on: https://chromium-review.googlesource.com/1028310
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#289}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/3046a67c2fc15041957df0e39e66b5d4892bcf44/chrome/browser/vr/ui_scene_creator.cc

Status: Fixed (was: Assigned)
Labels: Test-Complete
Status: Verified (was: Fixed)
Verified in build 67.0.3396.29 beta.  Looks good.

Sign in to add a comment