Cros splitscreen - Crash when setting opacity |
|||||
Issue descriptionChrome Version: 67.0.339 OS: Chrome What steps will reproduce the problem? (1) Open Files app, enter tablet mode and enter overview mode (2) Drag the Files app to snap to one side of the screen (3) Drag the divider to start resizing What is the expected result? The Files app can be resized correctly What happens instead? Chrome crashes It's caused by a negative opacity value Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 27 2018
,
Apr 28 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 30 2018
Has this been tested on ToT and multiple boards with expected results?
,
Apr 30 2018
Yes it has been tested on devices on tot.
,
May 1 2018
Approving merge to M67 Chrome OS.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4be5f7ed8f0b37621d7842441acd6f4fd9bf5a8 commit b4be5f7ed8f0b37621d7842441acd6f4fd9bf5a8 Author: Xiaoqian Dai <xdai@chromium.org> Date: Thu May 03 05:31:40 2018 [Merge to M67] Cros splitscreen: Fix crash when setting opacity. It's possible that when setting the opacity of the black scrim, the opacity is a very small negative value. Set it to zero in this case. Bug: 835900 TBR=oshima@chromium.org (cherry picked from commit 309a72e6883b7f09617bdc330db1305045bf6e81) Change-Id: Ia3b082e86cb5cca25987023a9a6f46625865b335 Reviewed-on: https://chromium-review.googlesource.com/1024243 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554474} Reviewed-on: https://chromium-review.googlesource.com/1041577 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#452} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/b4be5f7ed8f0b37621d7842441acd6f4fd9bf5a8/ash/wm/splitview/split_view_controller.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 27 2018