VR: Don't vertically move omnibox during fade-in |
|||||||
Issue descriptionIn lieu of the complete specified omnibox-slide-in-then-keyboard-rotate-in sequence, we should not move the omnibox at all.
,
Apr 23 2018
,
Apr 23 2018
cmasso@, apologies for the direct request here - could we bypass the 24-hour auto-approve cycle for this change? It's a trivial change, and will be very helpful for a demonstration later this week if we can get it into 67. Thanks for the consideration!
,
Apr 23 2018
Approving the merge as per our offline discussion. Make sure to verify the fix in M67 after merging it.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6d175f22797f57e97151260700ddafca7de22fb commit c6d175f22797f57e97151260700ddafca7de22fb Author: Christopher Grant <cjgrant@chromium.org> Date: Mon Apr 23 21:26:39 2018 VR: Get rid of vertical animation on the omnibox The full spec for omnibox appearing is a fade-in and slide-in from below, followed by the keyboard fading and rotating up into place. Because the keyboard doesn't currently animate as expected, we have the omnibox slide behind an already visible keyboard, which is not good. This change makes the omnibox simply fade in at its target location. BUG= 835896 R=bshe Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Idb68cb9120b144aff0251e39586064a0423fbc1e Reviewed-on: https://chromium-review.googlesource.com/1024240 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552776} Reviewed-on: https://chromium-review.googlesource.com/1024958 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#242} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/c6d175f22797f57e97151260700ddafca7de22fb/chrome/browser/vr/ui_scene_creator.cc
,
Apr 23 2018
Tested on a local M-67 checkout cherry-pick, and re-tested by building the tip of the branch after the merge. Thanks for expediting this, cmasso@!
,
May 8 2018
Verified on build 67.3396.29 beta. Looks good. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 23 2018