New issue
Advanced search Search tips

Issue 835895 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 797979



Sign in to add a comment

New subframes for Capping Heavy Pages should get the pause state of the parent frame.

Project Member Reported by ryansturm@chromium.org, Apr 23 2018

Issue description

A new frame could be created at the wrong time (or after pausing), currently these frames do not inherit pause state from the parent frame, but they likely should.
 
Blockedon: 797979

Comment 2 by bengr@chromium.org, Jun 5 2018

Labels: -M-68 M-69
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed7ae1102dd41090aa4bf5dbf31854c6435cbd0

commit fed7ae1102dd41090aa4bf5dbf31854c6435cbd0
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jun 08 16:45:10 2018

Adding subframe pausing for new frames in page load capping

This adds frame pausing when new frames are created.

This also changes the browsertests to use the infobar.

Bug:  835895 
Change-Id: I79d92bd91ad0482f41a26b0f1ceaddd88d798abb
Reviewed-on: https://chromium-review.googlesource.com/1091496
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565656}
[modify] https://crrev.com/fed7ae1102dd41090aa4bf5dbf31854c6435cbd0/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
[modify] https://crrev.com/fed7ae1102dd41090aa4bf5dbf31854c6435cbd0/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc
[modify] https://crrev.com/fed7ae1102dd41090aa4bf5dbf31854c6435cbd0/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h

Status: Fixed (was: Assigned)

Sign in to add a comment