Gray box in place of navigation bar. |
||||||||||||||||
Issue descriptionChrome Version : 68.0.3402.0 URLs (if applicable) : https://www.buzzfeed.com/cassiesmyth/jane-the-virgin-theories-after-that-episode?utm_term=.bqGadnzNG#.vr6eamEYV Other browsers tested: N/A Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: Firefox: Edge: Chrome Version: (copy from chrome://version) OS: iOS What steps will reproduce the problem? (1) From NTP navigate to url above. (2) Press back button. (3) What is the expected result? Navigation back to NTP. What happens instead? Gray box takes place of full navigation bar. Please provide any additional information below. Attach a screenshot if possible.
,
Apr 25 2018
eugenbut@ could you PTAL?
,
Apr 25 2018
,
Apr 25 2018
FYI, this is happening on M66 and M67 as well
,
Apr 25 2018
This is a URL spoofing bug. If the start page is not NTP, the UI is not broken, but omnibox URL is incorrect.
,
Apr 25 2018
,
Apr 25 2018
,
Apr 25 2018
This back navigation is considered as same-document navigation, because Buzzfeed navigation item was marked as is_created_from_hash_change_. Any page can send window.hashchange and cause URL spoofing, so is_created_from_hash_change_ flag should not be trusted.
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66fd7076b18a56324e16f6cf8a064b0a8cd39824 commit 66fd7076b18a56324e16f6cf8a064b0a8cd39824 Author: Eugene But <eugenebut@google.com> Date: Thu Apr 26 15:57:14 2018 Fix isSameDocumentNavigationBetweenItem:andItem:. Bug: 835876 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I82cc36ec7ffbeea3311cf385130a33547216c56b Reviewed-on: https://chromium-review.googlesource.com/1028996 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#554043} [modify] https://crrev.com/66fd7076b18a56324e16f6cf8a064b0a8cd39824/ios/web/navigation/crw_session_controller.mm [modify] https://crrev.com/66fd7076b18a56324e16f6cf8a064b0a8cd39824/ios/web/navigation/crw_session_controller_unittest.mm
,
Apr 26 2018
,
Apr 26 2018
,
Apr 26 2018
This bug requires manual review: Less than 29 days to go before AppStore submit on M67 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
Let's verify this fix on canary before moving forward. Thanks!
,
Apr 27 2018
Verified on M68.0.3410.0 Canary iOS 11.4 iPhoneX URL, content area updated correctly after navigating Back and Forward from buzzfeed.com
,
Apr 27 2018
,
Apr 27 2018
Thanks Srikanth! Approved the merge.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee1f6337d3cd5d89f6112b1f6062ff87bd22103c commit ee1f6337d3cd5d89f6112b1f6062ff87bd22103c Author: Eugene But <eugenebut@google.com> Date: Fri Apr 27 18:07:50 2018 Fix isSameDocumentNavigationBetweenItem:andItem:. TBR=eugenebut@google.com (cherry picked from commit 66fd7076b18a56324e16f6cf8a064b0a8cd39824) Bug: 835876 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I82cc36ec7ffbeea3311cf385130a33547216c56b Reviewed-on: https://chromium-review.googlesource.com/1028996 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554043} Reviewed-on: https://chromium-review.googlesource.com/1033454 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#352} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/ee1f6337d3cd5d89f6112b1f6062ff87bd22103c/ios/web/navigation/crw_session_controller.mm [modify] https://crrev.com/ee1f6337d3cd5d89f6112b1f6062ff87bd22103c/ios/web/navigation/crw_session_controller_unittest.mm
,
Aug 3
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by kariahda@chromium.org
, Apr 23 2018