When the UIRefreshPhase1 flag is enabled, there is no share button on phone in portrait orientations. This is causing ActivityServiceControllerTst.testActivityServiceControllerIsDisabled to fail.
@stk should this go to you or to gambard? Please triage and add the correct set of labels, thanks!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/662e96bd0bf586e5f10e7809288fd194a739b8f7 commit 662e96bd0bf586e5f10e7809288fd194a739b8f7 Author: Rohit Rao <rohitrao@chromium.org> Date: Mon Apr 23 19:30:31 2018 [ios] Fixes UI egtests when the UIRefresh flag is enabled. KeyboardCommandsTestCase.testKeyboardCommandsNotRegistered_AddBookmarkPresented and ToolbarTestCase.testToolbarOmniboxTyping are updated with matches for the correct elements. ActivityServiceControllerTestCase.testActivityServiceControllerIsDisabled and TabSwitcherTransitionTestCase.testRotationsWhileSwitcherIsNotActive are disabled, because these tests are exposing UIRefresh bugs. BUG= 825431 , 835860 , 835871 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I805e4b29ce59b88eb63016d4d2687c9043c72f5b Reviewed-on: https://chromium-review.googlesource.com/1023718 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552790} [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/keyboard_commands_egtest.mm [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
This should be fixed now with https://chromium-review.googlesource.com/c/chromium/src/+/1012064
I need to mention, it's fixed but only with Refresh Location Bar flag. Also, I am keeping this bug open to track the disabled tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f214555c63f5e69446adf4be717b413e54334efd commit f214555c63f5e69446adf4be717b413e54334efd Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Jul 18 14:14:45 2018 Reenable tests using openShareMenu. - Reenable tests that rely on the share menu. - Fix -openShareMenu test helper - Fix location bar's trailing button accessibility: now it's correctly updated when it's switched between voice search and share. Bug: 849932 , 835871 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I01101fb34ce57464e2722a753e5e3ad9c71bbd3f Reviewed-on: https://chromium-review.googlesource.com/1140161 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576032} [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_consumer.h [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.h [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/print/print_controller_egtest.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/f214555c63f5e69446adf4be717b413e54334efd/ios/chrome/test/earl_grey/chrome_matchers.mm
Verified on iPhone 6+ iOS 11.4, iPhone 7+ iOS 10.3.3 , iPad Pro 12'9 iOS 11.4.1 on 69.0.3497.50 Beta .Share is preset in portrait mode.
Comment 1 by rohitrao@chromium.org
, Apr 23 2018