New issue
Advanced search Search tips

Issue 835865 link

Starred by 2 users
Status: Assigned
Owner:
dvadym@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

UsernameChangedAfterPasswordInput_FormSubmitted is timing out on win

Project Member Reported by xidac...@chromium.org, Apr 23 2018
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b97ad368aeef368c0099fdb9f1718694c8727b65

commit b97ad368aeef368c0099fdb9f1718694c8727b65
Author: Xida Chen <xidachen@chromium.org>
Date: Mon Apr 23 16:41:57 2018

Disable UsernameChangedAfterPasswordInput_FormSubmitted on win

TBR=thestig@chromium.org
NOTRY=true

Bug: 835865
Change-Id: Iaa027cb963cf6bd49bb4871bdedfc8ae0428020c
Reviewed-on: https://chromium-review.googlesource.com/1024202
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552727}
[modify] https://crrev.com/b97ad368aeef368c0099fdb9f1718694c8727b65/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Comment 2 by thestig@chromium.org, Apr 23 2018

Components: UI>Browser>Passwords
Labels: OS-Windows
Sample output from https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948442896109817664%2F%2B%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPasswordAutofillAgentTest.UsernameChangedAfterPasswordInput_FormSubmitted%2F0

[ RUN      ] PasswordAutofillAgentTest.UsernameChangedAfterPasswordInput_FormSubmitted
../../content/public/test/render_view_test.cc(381): error: Expected equality of these values:
  0u
    Which is: 0
  result->number_of_live_documents
    Which is: 1
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x03C9D0DA+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x03CB894A+74]
	testing::internal::AssertHelper::operator= [0x03CB831B+75]
	std::forward<mojo::StructPtr<blink::mojom::LeakDetectionResult> > [0x06CC10C8+904]
	std::forward<mojo::StructPtr<blink::mojom::LeakDetectionResult> > [0x06CC0EB8+376]
	std::forward<mojo::StructPtr<blink::mojom::LeakDetectionResult> > [0x06CC0DD6+150]
	base::OnceCallback<void __cdecl(mojo::StructPtr<blink::mojom::LeakDetectionResult>)>::OnceCallback<void __cdecl(mojo::StructPtr<blink::mojom::LeakDetectionResult>)> [0x06CC0D16+182]
	std::forward<std::default_delete<blink::mojom::LeakDetectorProxy> > [0x06CC0B40+144]
	base::OnceCallback<void __cdecl(mojo::StructPtr<blink::mojom::LeakDetectionResult>)>::Run [0x59BCF56D+109]
	blink::mojom::LeakDetector_PerformLeakDetection_ForwardToCallback::Accept [0x59BCF319+553]
	mojo::InterfaceEndpointClient::HandleValidatedMessage [0x6C0508EF+1599]
	mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept [0x6C050290+32]
	mojo::FilterChain::Accept [0x6C04DFD1+465]
	mojo::InterfaceEndpointClient::HandleIncomingMessage [0x6C053A55+229]
	mojo::internal::MultiplexRouter::ProcessIncomingMessage [0x6C06A49D+1533]
	mojo::internal::MultiplexRouter::Accept [0x6C069945+645]
	mojo::FilterChain::Accept [0x6C04DFD1+465]
	mojo::Connector::ReadSingleMessage [0x6C039EB0+960]
	mojo::Connector::ReadAllAvailableMessages [0x6C03B36D+109]
	mojo::Connector::OnHandleReadyInternal [0x6C03B055+261]
	mojo::Connector::OnWatcherHandleReady [0x6C03AF3D+29]

../../content/public/test/render_view_test.cc(382): error: Expected equality of these values:
  0u
    Which is: 0
  result->number_of_live_nodes
    Which is: 24
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x03C9D0DA+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x03CB894A+74]
	testing::internal::AssertHelper::operator= [0x03CB831B+75]
	std::forward<mojo::StructPtr<blink::mojom::LeakDetectionResult> > [0x06CC119E+1118]
	std::forward<mojo::StructPtr<blink::mojom::LeakDetectionResult> > [0x06CC0EB8+376]
	std::forward<mojo::StructPtr<blink::mojom::LeakDetectionResult> > [0x06CC0DD6+150]
	base::OnceCallback<void __cdecl(mojo::StructPtr<blink::mojom::LeakDetectionResult>)>::OnceCallback<void __cdecl(mojo::StructPtr<blink::mojom::LeakDetectionResult>)> [0x06CC0D16+182]
	std::forward<std::default_delete<blink::mojom::LeakDetectorProxy> > [0x06CC0B40+144]
	base::OnceCallback<void __cdecl(mojo::StructPtr<blink::mojom::LeakDetectionResult>)>::Run [0x59BCF56D+109]
	blink::mojom::LeakDetector_PerformLeakDetection_ForwardToCallback::Accept [0x59BCF319+553]
	mojo::InterfaceEndpointClient::HandleValidatedMessage [0x6C0508EF+1599]
	mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept [0x6C050290+32]
	mojo::FilterChain::Accept [0x6C04DFD1+465]
...
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d4ecf411bdfca7d29ba2ef47ec1182978fb634b

commit 7d4ecf411bdfca7d29ba2ef47ec1182978fb634b
Author: Xida Chen <xidachen@chromium.org>
Date: Mon Apr 23 19:00:22 2018

Add a line of comment for disabling a test on win

In my previous CL
https://chromium-review.googlesource.com/c/chromium/src/+/1024202, I
disabled a test without proper comments. This CL adds a line of comment
referencing the associated bug.

TBR=thestig@chromium.org
NOTRY=true

Bug: 835865
Change-Id: I191efd833b6327d26fa2077b431a78fcc9eb8ce4
Reviewed-on: https://chromium-review.googlesource.com/1024377
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552778}
[modify] https://crrev.com/7d4ecf411bdfca7d29ba2ef47ec1182978fb634b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
►

Sign in to add a comment