TabGrid does not handle rotations properly when hidden |
|||||||
Issue descriptionThis was discovered by TabSwitcherTransitionTest.testRotationsWhileSwitcherIsNotActive. Repro steps (from the test): 1) Launch app in portrait, enter tab grid. 2) Select the current tab to exit tab grid. 3) Rotate device to landscape. 4) Enter tab grid. Select the current tab to exit tab grid. 5) Rotate device back to portrait. 6) Enter tab grid. At step #4, the correct panel is displayed but all of the tabs are shifted to the right. At step #6, the recent tabs panel is displayed on phone, or half of the recent tabs panel is displayed on tablet. The root cause is related to a rotation that is done while the BVC is active.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/662e96bd0bf586e5f10e7809288fd194a739b8f7 commit 662e96bd0bf586e5f10e7809288fd194a739b8f7 Author: Rohit Rao <rohitrao@chromium.org> Date: Mon Apr 23 19:30:31 2018 [ios] Fixes UI egtests when the UIRefresh flag is enabled. KeyboardCommandsTestCase.testKeyboardCommandsNotRegistered_AddBookmarkPresented and ToolbarTestCase.testToolbarOmniboxTyping are updated with matches for the correct elements. ActivityServiceControllerTestCase.testActivityServiceControllerIsDisabled and TabSwitcherTransitionTestCase.testRotationsWhileSwitcherIsNotActive are disabled, because these tests are exposing UIRefresh bugs. BUG= 825431 , 835860 , 835871 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I805e4b29ce59b88eb63016d4d2687c9043c72f5b Reviewed-on: https://chromium-review.googlesource.com/1023718 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552790} [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/keyboard_commands_egtest.mm [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
,
Apr 23 2018
,
Apr 24 2018
,
Jun 27 2018
This appears fixed now.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/257ad1da276c146d91602aa0b713d70d94fe6247 commit 257ad1da276c146d91602aa0b713d70d94fe6247 Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Jul 27 12:44:01 2018 [ios] Reenable testRotationsWhileSwitcherIsNotActive. BUG= 835860 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ide83ee27d1a888a08787b8726c0e5cc80fe80f03 Reviewed-on: https://chromium-review.googlesource.com/1148018 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578614} [modify] https://crrev.com/257ad1da276c146d91602aa0b713d70d94fe6247/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm
,
Jul 31
Reopen Version: Chrome Canary 70.0.3508.0 Device: iPhone iOS: 11.4 Still looking at tabs shifted to the right and portrait issue https://drive.google.com/open?id=1h0B4HRlnHRLP5iFohLrP2GfEBLauB5k3
,
Aug 2
thegreenfrog@, can you take this since you've been working on tab grid rotations?
,
Aug 2
This was fixed with this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1153391 Merging into appropriate bug. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rohitrao@chromium.org
, Apr 23 2018