IndependentOTRProfileManagerTest.CallbackNotCalledAfterUnregister is flaky on Mac |
|||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=IndependentOTRProfileManagerTest.CallbackNotCalledAfterUnregister https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948497506377900848%2F%2B%2Fsteps%2Fbrowser_tests_on_Mac-10.10%2F0%2Flogs%2FIndependentOTRProfileManagerTest.CallbackNotCalledAfterUnregister%2F0 [ RUN ] IndependentOTRProfileManagerTest.CallbackNotCalledAfterUnregister [44088:4867:0422/180200.227816:WARNING:notification_platform_bridge_mac.mm(509)] AlertNotificationService: XPC connection invalidated. [18:02:00.318] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181 ... <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1' [18:02:00.393] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245 [18:02:00.393] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946 ... ../../chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc:329: Failure Value of: destroyed Actual: false Expected: true Stack trace: 0 browser_tests 0x0000000104d7b97b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 browser_tests 0x0000000104d7b339 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 browser_tests 0x0000000103b4b78e IndependentOTRProfileManagerTest_CallbackNotCalledAfterUnregister_Test::RunTestOnMainThread() + 558 3 browser_tests 0x00000001071592a3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 515 4 browser_tests 0x0000000106c7a7e9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4233
,
Apr 26 2018
Brandon, can you also take a look at this (could be related to Bug 837236 )?
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88ebf4f63a1960be3139ff3aea8045aeb40ea010 commit 88ebf4f63a1960be3139ff3aea8045aeb40ea010 Author: btolsch <btolsch@chromium.org> Date: Mon Apr 30 21:13:23 2018 Wait for OnBrowserRemoved after closing window in tests Some IndependentOTRProfileManager tests need to wait for a browser window and its associated Browser object to be destroyed. This was originally done with base::RunLoop::RunUntilIdle, but this isn't necessarily sufficient and may be a source of flakes on Mac. Bug: 835834 , 837236 Change-Id: I8dfd71e45cea7df411693dbccb153f9554754809 Reviewed-on: https://chromium-review.googlesource.com/1034279 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#554874} [modify] https://crrev.com/88ebf4f63a1960be3139ff3aea8045aeb40ea010/chrome/browser/media/router/presentation/independent_otr_profile_manager_browsertest.cc
,
May 2 2018
Marking fixed after ~24 hours of clean bots. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 23 2018