android_n5x_swarming_rel occasionally failing with Uncaught Exception: AssertionError |
||
Issue description
On experimental test failure, ANSR is occasionally failing with the following:
...
File "/b/rr/tmpFthU70/rw/checkout/scripts/slave/recipe_modules/test_utils/api.py", line 123, in run_tests_with_patch
elif t.failures(caller_api, 'with patch'):
File "/b/rr/tmpFthU70/rw/checkout/scripts/slave/recipe_modules/chromium_tests/steps.py", line 387, in failures
api, self._experimental_suffix(suffix))
File "/b/rr/tmpFthU70/rw/checkout/scripts/slave/recipe_modules/chromium_tests/steps.py", line 273, in failures
return self._test.failures(api, suffix)
File "/b/rr/tmpFthU70/rw/checkout/scripts/slave/recipe_modules/chromium_tests/steps.py", line 1507, in failures
assert self.has_valid_results(api, suffix)
AssertionError
from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/406088
This appears to be a bug in ExperimentalTest in which the wrapped test's implementation of failures can be called even if has_valid_results is false.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b33237a22a11aa6dfe76f91c0463d5e6d367cd08 commit b33237a22a11aa6dfe76f91c0463d5e6d367cd08 Author: John Budorick <jbudorick@chromium.org> Date: Mon Apr 23 15:32:01 2018 chromium_tests: Only call ExperimentalTest.failures if has_valid_results is True. Bug: 835822 Change-Id: I9938bd276a931db03167ed5646d4f522006de3e9 Reviewed-on: https://chromium-review.googlesource.com/1023978 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/b33237a22a11aa6dfe76f91c0463d5e6d367cd08/scripts/slave/recipe_modules/chromium_tests/tests/steps/experimental_test.py [modify] https://crrev.com/b33237a22a11aa6dfe76f91c0463d5e6d367cd08/scripts/slave/recipe_modules/chromium_tests/steps.py
,
Apr 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by jbudorick@chromium.org
, Apr 23 2018