New issue
Advanced search Search tips

Issue 835801 link

Starred by 1 user
Status: Verified
Owner:
mrsuyi@chromium.org
Closed: Aug 13
Cc:
marq@chromium.org
gambard@chromium.org
edchin@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

>99 tab smileys are different (nose or no nose?)

Project Member Reported by pkl@chromium.org, Apr 23 2018 
App Version (from "Chrome Settings > About Chrome"): 68.0.3401.0 canary
iOS Version: 11.2.6
Device: iPhone SE

Steps to reproduce: 
0. Have > 99 tabs

Observed behavior:
On the bottom toolbar, the smiley is :)
Enter tab grid and look at the segmented control at the top, the smiley is :-) 

Expected behavior: 
Use the same icon

Frequency: 
every time

Additional comments: 
I'm not sure if this is intentionally different, but wouldn't consistency be better?

Comment 1 by pkl@chromium.org, Apr 23 2018

IMG_3077.PNG
272 KB View Download
IMG_3078.jpg
424 KB View Download

Comment 2 by mard...@chromium.org, May 2 2018 

I don't mean to be nosy here but I think we should have a nose in both. It fits better with our UI but that's just my opinion.

Comment 3 by mard...@chromium.org, May 2 2018

Labels: Proj-UIRefresh

Comment 4 by pschaffner@chromium.org, May 18 2018

Components: Design

Comment 5 by pschaffner@chromium.org, May 22 2018

Cc: -edchin@chromium.org
Owner: edchin@chromium.org
What do we use in stable today? Whatever the answer, that is your answer to this bug.

Comment 6 by pkl@chromium.org, May 22 2018 

No nose.

Comment 7 by marq@chromium.org, Jun 27 2018

Labels: Q2

Comment 8 by edchin@chromium.org, Jun 27 2018

Labels: -M-69

Comment 9 by marq@chromium.org, Aug 7

Labels: -Q2 -Pri-2 M70 Pri-1

Comment 10 by marq@chromium.org, Aug 7

Labels: -Restrict-View-Google -M70 M-70

Comment 11 by marq@chromium.org, Aug 10

Cc: edchin@chromium.org
Owner: mrsuyi@chromium.org
We should consolidate the logic here to a single helper function.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5743ef0e3b3ff32a8318eee85b1dd67e7867c46

commit e5743ef0e3b3ff32a8318eee85b1dd67e7867c46
Author: Yi Su <mrsuyi@chromium.org>
Date: Mon Aug 13 11:59:26 2018

Fix bug of inconsistent button title for tabs count in toolbar and tab-grid

Add a helper function that returns text for tabs count:
(-inf, 0]   => ""
(0, 100)    => "num"
[100, +inf) => ":)"

Bug:  835801 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ica4607b10dbd1f241d4e5a07c32128a1f4607db8
Reviewed-on: https://chromium-review.googlesource.com/1172297
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582552}
[modify] https://crrev.com/e5743ef0e3b3ff32a8318eee85b1dd67e7867c46/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm
[modify] https://crrev.com/e5743ef0e3b3ff32a8318eee85b1dd67e7867c46/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/e5743ef0e3b3ff32a8318eee85b1dd67e7867c46/ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.mm
[modify] https://crrev.com/e5743ef0e3b3ff32a8318eee85b1dd67e7867c46/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/e5743ef0e3b3ff32a8318eee85b1dd67e7867c46/ios/chrome/browser/ui/uikit_ui_util.mm

Comment 13 by mrsuyi@chromium.org, Aug 13

Status: Fixed (was: Assigned)

Comment 14 by pmadalla@chromium.org, Aug 21

Status: Verified (was: Fixed)
Verified the issue on the build 70.0.3529.0 canary tested in iPhone7+(iOS 11.4.1).
Smileys after opening 99 tabs are same in Normal and Tabswitcher mode,looks good.
►

Sign in to add a comment