[ChromeOS] Enable GalleryBrowserTests |
|||
Issue descriptionGalleryBrowserTests had been disabled due to flakiness. With that test suite in maintenance mode, other changes in chrome code over time have increased the likelihood of flakes in this test suite, resulting in blanket sheriff test disables ( issue 804413 ), often for causes unrelated to the original flakiness bug report, or disabled with no investigation at all. The systemic cause of the browser test flakes in the FileManagerBrowserTest test suite was recently investigated / resolved ( issue 831074 , issue 804413 , issue 829310 ). Hence, we do not expect any flakiness in this test suite anymore, and we should start working to re-enable this browser test suite. This issue covers the Gallery tests in that test suite.
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c124b015e46ca467e09e3715252d55f4598a5b98 commit c124b015e46ca467e09e3715252d55f4598a5b98 Author: Noel Gordon <noel@chromium.org> Date: Tue Apr 24 10:58:14 2018 Re-enable GalleryBrowserTest.OpenMultipleImagesOnDownloads in DEBUG Fixed on issue 831074 issue 804413 issue 829310 . Tbr: yamaguchi-san Bug: 835794 , 803505 Change-Id: I1a9e3a80a57dd32de63c1dd28e5fc10f7e4ad90b Reviewed-on: https://chromium-review.googlesource.com/1025436 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553047} [modify] https://crrev.com/c124b015e46ca467e09e3715252d55f4598a5b98/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/652673aa18a6d4217fa12dca1773d8fc04a87cb7 commit 652673aa18a6d4217fa12dca1773d8fc04a87cb7 Author: Noel Gordon <noel@chromium.org> Date: Tue Apr 24 11:34:54 2018 Re-enable some GalleryBrowserTests for MSAN These tests have been running under, or re-enabled for, ASAN and are working well there. Time to re-enable under MSAN issue 508949 to see see if that issue (OOM) is still a problem. The expected answer is: no, it's not a problem for this browser test suite anymore. Let's see. Tbr: yamaguchi-san Bug: 835794 ,508949 Change-Id: Ia6e2a0164872b315fd060d8fa6c49f65b7e3c0ed Reviewed-on: https://chromium-review.googlesource.com/1025439 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553050} [modify] https://crrev.com/652673aa18a6d4217fa12dca1773d8fc04a87cb7/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124238f4424a05e57558c0f309ac011e4fe0b76a commit 124238f4424a05e57558c0f309ac011e4fe0b76a Author: Noel Gordon <noel@chromium.org> Date: Tue Apr 24 12:53:06 2018 Re-enable GalleryBrowserTest.RotateImageOnDrive in DEBUG Fixed on issue 831074 issue 804413 issue 829310 . Tbr: yamaguchi-san Bug: 835794 , 690983 Change-Id: Ia92b6e5a096760c747ebb20802dc59f07f918ea5 Reviewed-on: https://chromium-review.googlesource.com/1025850 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553063} [modify] https://crrev.com/124238f4424a05e57558c0f309ac011e4fe0b76a/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b22e00acf01de087a8abadf5689c6e057ea02275 commit b22e00acf01de087a8abadf5689c6e057ea02275 Author: Noel Gordon <noel@chromium.org> Date: Thu Apr 26 08:49:13 2018 Re-enable remaining GalleryBrowserTests and all bots Flakiness cause in the FileManagerBrowserTests was resolved on issues: issue 831074 issue 804413 issue 829310 . Allow these tests to run in DEBUG/MSAN/ASAN after the previous patches on the bug selectively enabled subsets of the GalleryBrowserTest tests on those bots and are working well [1]. [1] https://bit.ly/2HKT7kc Bug: 835794 Change-Id: I4cf7c412c51cf051283a8f8fea9a5d1118af8f51 Reviewed-on: https://chromium-review.googlesource.com/1025854 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553956} [modify] https://crrev.com/b22e00acf01de087a8abadf5689c6e057ea02275/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
May 7 2018
,
May 7 2018
,
May 7 2018
GalleryBrowserTestInGuestMode.MAYBE_OpenSingleImageOnDownloads ??? That test hasn't existed for years, and there's no such test in the code. Dunno how to remove old tests like this from the flakiness dashboard. Would sure <3 a way to do that, +dpranke
,
May 10 2018
It looks like a test by that name still exists and is still running: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/gallery_browsertest.cc?l=37 the "MAYBE_" part is a preprocessor, not part of the actual test name. AFAIK, we won't display tests that don't have real data associated with them. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 23 2018