New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 829697



Sign in to add a comment

Remove //third_party/WebKit/Tools/run-perf-test.cfg

Project Member Reported by tkent@chromium.org, Apr 23 2018

Issue description

We should move //third_party/WebKit/Tools/run-perf-test.cfg to somewhere in //third_party/blink/ because we'll remove //third_party/WebKit.
Probably, the destination is //third_party/blink/perf_tests/ or //third_party/blink/tools/.

simonhatch@, can you work on this?

 
Cc: dtu@chromium.org eyaich@chromium.org
Components: Speed>Bisection
Also: When can run-perf-test.cfg be removed? Is it used for anything anymore? (It was used for try jobs of Blink performance tests, right?)

Comment 2 by eyaich@chromium.org, Apr 23 2018

Cc: nednguyen@chromium.org
It was for the original bisect script, and isn't used for anything anymore. I believe the chromium side ones were cleaned up last year. I'll upload a cl removing this.

Comment 4 by tkent@chromium.org, Apr 24 2018

Summary: Remove //third_party/WebKit/Tools/run-perf-test.cfg (was: Move //third_party/WebKit/Tools/run-perf-test.cfg to //third_party/blink/)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ee5be1c053fb05afcc747de212143e709e98b2

commit 36ee5be1c053fb05afcc747de212143e709e98b2
Author: Simon <simonhatch@chromium.org>
Date: Tue Apr 24 15:42:46 2018

Remove run-perf-test.cfg from third_party/WebKit/Tools

This was originally used for the first iteration of the bisect script,
which was turned down in 2015. Looks like the chromium side was cleaned
up but not the WebKit side.

Bug:  835724 
Change-Id: I45c862a967cb32fd522be01d162af54cb2ea8ee2
Reviewed-on: https://chromium-review.googlesource.com/1024200
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553136}
[delete] https://crrev.com/c57c12cc95656a712fc41bf5f391c4cec1bc18b0/third_party/WebKit/Tools/PRESUBMIT.py
[delete] https://crrev.com/c57c12cc95656a712fc41bf5f391c4cec1bc18b0/third_party/WebKit/Tools/run-perf-test.cfg

Status: Fixed (was: Assigned)

Sign in to add a comment