video_VideoEncodeAccelerator autotest failed at nyan family |
||||
Issue descriptionBroad: nyan_big, nyan_blaze, nyan_kitty Version: 10608.0.0 Actually the failure is continuous for a long time. Error message: <ForceKeyframes/VideoEncodeAcceleratorTest.TestSimpleEncode/0>: ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:2006; Expected: (num_keyframes_requested_) <= (1UL), actual: 2 vs 1; Complete log: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/194208868-chromeos-test/chromeos4-row13-rack2-host11 Dashboard: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=video_VideoEncodeAccelerator&suite=&daysBack=7&board=&architecture=&boardFamily=nyan&buildConfig=&reason=&version=&milestone=68&dut=&token=ALeBcqEVt7d1jBVYHgYNWHj7Zfhh%3A1524462313556
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346edc8cb24109e174aff29a8aee99545d4a9abe commit 346edc8cb24109e174aff29a8aee99545d4a9abe Author: Chih-Yu Huang <akahuang@google.com> Date: Tue Sep 04 08:11:20 2018 VEA unittest: Fix the check of keyframe number. Originally when we check the keyframe behavior, we track the number difference by variable |num_keyframes_requested_|. The variable is incremented when we ask encoder to encode a keyframe, and decremented when we got the encoded keyframe buffer. However, these two flows are not synchronized. That is, when checking the behavior at the middle of the stream, we only receive half of frames but already encode more than half of frames. The mismatch causes the test failed. In this CL, we check each requested keyframe is received during the loop, and refactor the implementation for readability. BUG= 835716 TEST=Run VEA unittest on nyan_big and eve device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52f53523b741df12fbac9fd00a02bbbd68547267 Reviewed-on: https://chromium-review.googlesource.com/1168950 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588471} [modify] https://crrev.com/346edc8cb24109e174aff29a8aee99545d4a9abe/media/gpu/video_encode_accelerator_unittest.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346edc8cb24109e174aff29a8aee99545d4a9abe commit 346edc8cb24109e174aff29a8aee99545d4a9abe Author: Chih-Yu Huang <akahuang@google.com> Date: Tue Sep 04 08:11:20 2018 VEA unittest: Fix the check of keyframe number. Originally when we check the keyframe behavior, we track the number difference by variable |num_keyframes_requested_|. The variable is incremented when we ask encoder to encode a keyframe, and decremented when we got the encoded keyframe buffer. However, these two flows are not synchronized. That is, when checking the behavior at the middle of the stream, we only receive half of frames but already encode more than half of frames. The mismatch causes the test failed. In this CL, we check each requested keyframe is received during the loop, and refactor the implementation for readability. BUG= 835716 TEST=Run VEA unittest on nyan_big and eve device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52f53523b741df12fbac9fd00a02bbbd68547267 Reviewed-on: https://chromium-review.googlesource.com/1168950 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588471} [modify] https://crrev.com/346edc8cb24109e174aff29a8aee99545d4a9abe/media/gpu/video_encode_accelerator_unittest.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346edc8cb24109e174aff29a8aee99545d4a9abe commit 346edc8cb24109e174aff29a8aee99545d4a9abe Author: Chih-Yu Huang <akahuang@google.com> Date: Tue Sep 04 08:11:20 2018 VEA unittest: Fix the check of keyframe number. Originally when we check the keyframe behavior, we track the number difference by variable |num_keyframes_requested_|. The variable is incremented when we ask encoder to encode a keyframe, and decremented when we got the encoded keyframe buffer. However, these two flows are not synchronized. That is, when checking the behavior at the middle of the stream, we only receive half of frames but already encode more than half of frames. The mismatch causes the test failed. In this CL, we check each requested keyframe is received during the loop, and refactor the implementation for readability. BUG= 835716 TEST=Run VEA unittest on nyan_big and eve device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52f53523b741df12fbac9fd00a02bbbd68547267 Reviewed-on: https://chromium-review.googlesource.com/1168950 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588471} [modify] https://crrev.com/346edc8cb24109e174aff29a8aee99545d4a9abe/media/gpu/video_encode_accelerator_unittest.cc
,
Sep 7
Issue 725366 has been merged into this issue.
,
Oct 23
The test went green. Close the issue.
,
Nov 1
We found the autotest is flaky at M-70 ( crbug.com/900828 ). Could I cherry-pick the fixed CL at #4 back to M-70?
,
Nov 19
This looks to be a test only fix? M71 is a few weeks away. Do we need this in M70?
,
Nov 20
Hmm I think it's not needed now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by benhenry@chromium.org
, Aug 3