Umbrella bug for tracking progress on Site Settings / All Sites. This will refer to the future #site-settings flag (currently #enable-site-settings) and includes improvements to Content Settings / All Sites, moves to ELTD+1 scoping in some places, and improvements to Site Details. Mocks: https://docs.google.com/presentation/d/1g4kvpO1cu_k03IzBejglc2IbJa5UvpiJmVL-XPsKPvA/edit?disco=AAAABnOwtrA&ts=5ac66a6b
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/deade797509de5c87a1259e3d1d90cf2ae54423b commit deade797509de5c87a1259e3d1d90cf2ae54423b Author: Patti <patricialor@chromium.org> Date: Fri Apr 27 02:59:40 2018 Settings: Convert site settings / all sites from a switch to a feature. Features provide more flexibility by having a default state, so switch to using a feature for launching via waterfall when Site settings / All sites is complete. Bug: 835712 Change-Id: I9c21477f791420582ea896ccb89eae2c04e24a9c Reviewed-on: https://chromium-review.googlesource.com/1023076 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#554273} [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/browser/about_flags.cc [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/common/chrome_features.cc [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/common/chrome_features.h [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/common/chrome_switches.cc [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/common/chrome_switches.h [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/deade797509de5c87a1259e3d1d90cf2ae54423b/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47 commit dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47 Author: Patti <patricialor@chromium.org> Date: Thu May 03 02:35:51 2018 Settings: Update Site Settings page for All Sites. Update the "Site Settings" page in chrome://settings with new strings and add headings. This change is gated behind the #site-settings flag. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I944e14d1009a96f6728a9dbd0917136c27894fe5 Reviewed-on: https://chromium-review.googlesource.com/1036707 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555655} [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/app/settings_strings.grdp [add] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/app/settings_strings_grdp/IDS_SETTINGS_SITE_SETTINGS_ALL_SITES_DESCRIPTION.png.sha1 [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [modify] https://crrev.com/dc2db3f9f9ea05f7afb1d0f9cde0f05d4c918c47/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ed26799650cf921f84e6d2dffed292408facb31 commit 9ed26799650cf921f84e6d2dffed292408facb31 Author: Patti <patricialor@chromium.org> Date: Mon May 07 02:56:32 2018 Settings: Create a new element for All Site / site list items. Currently, All Site list entries are not reuseable. These will eventually become entries that represent an ETLD+1 site, with a list of origins as its children, so factor out the existing entries into a separate Polymer element. This is needed as they will also in future be used as site-list entries. This patch also fixes the UI in All Sites to have entries on a single line, when previously the icon, origin and arrow displayed were misaligned. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I66315496599f8c8d04309048ca897585a3bb431c Reviewed-on: https://chromium-review.googlesource.com/1041628 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#556370} [modify] https://crrev.com/9ed26799650cf921f84e6d2dffed292408facb31/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/9ed26799650cf921f84e6d2dffed292408facb31/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/9ed26799650cf921f84e6d2dffed292408facb31/chrome/browser/resources/settings/site_settings/all_sites.js [add] https://crrev.com/9ed26799650cf921f84e6d2dffed292408facb31/chrome/browser/resources/settings/site_settings/site_entry.html [add] https://crrev.com/9ed26799650cf921f84e6d2dffed292408facb31/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/9ed26799650cf921f84e6d2dffed292408facb31/chrome/test/data/webui/settings/all_sites_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cbf59d466b9fc793e4a4726349548b87b580d0b commit 8cbf59d466b9fc793e4a4726349548b87b580d0b Author: Patti <patricialor@chromium.org> Date: Wed May 30 04:20:41 2018 Settings: All Sites - move most client-side processing to the back-end. Add a specialized C++ function to retrieve all sites. This removes the need for client-side processing to de-dup and filter patterns retrieved from a more general query that just fetches all exceptions. Also add tests for the C++ and JS. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I820814f9903c9ba66f31414970d21c625b1c1b81 Reviewed-on: https://chromium-review.googlesource.com/1074780 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#562730} [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/8cbf59d466b9fc793e4a4726349548b87b580d0b/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c83652a33127a0d4ec9b723e344b854f8f752a commit d4c83652a33127a0d4ec9b723e344b854f8f752a Author: Patti <patricialor@chromium.org> Date: Thu Jun 07 07:08:32 2018 MD Settings: Fix trashing site usage via Site Details. Site Details was calling a function that didn't exist when the user clicks the trash can button to delete site hard disk usage. Fix. Also add a confirmation dialog, update strings, and move the position of the reset settings button when #enable-site-settings is turned on. Manual test - with #enable-site-settings turned on, navigate to a site using hard disk usage (typically https://www.google.com works). Open the Page Info bubble, click "Site settings". When Site Details opens, it should say 'Usage' in one of the headings. Click the clear data button next to the amount of usage displayed, confirm the dialog, then verify it now shows a string that says 'No usage data'. Bug: 752859 , 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f89a60bcc3c63bebee82eae288460f51aabca0a Reviewed-on: https://chromium-review.googlesource.com/616503 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#565205} [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/app/settings_strings.grdp [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/test/data/webui/settings/site_details_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9256dbd163a01222fe3eb379f1a34ca32ff721b6 commit 9256dbd163a01222fe3eb379f1a34ca32ff721b6 Author: Patti <patricialor@chromium.org> Date: Wed Jun 13 04:37:44 2018 Settings: All Sites front-end now displays sites grouped by eTLD+1. Site settings's All Sites back end was updated in r562730 to group sites by their eTLD+1. This patch updates the front end to match. Clicking on an eTLD+1 group will expand the list to show all relevant origins under it, and clicking one of those origins retains the previous behavior where it will navigate to Site Details. Similarly sites that have no eTLD+1 group will retain existing behavior. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I075a1befd49211d0a3b29820ea3aa71887f9dd0e Reviewed-on: https://chromium-review.googlesource.com/1088274 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#566720} [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/test/data/webui/settings/cr_settings_browsertest.js [add] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/9256dbd163a01222fe3eb379f1a34ca32ff721b6/chrome/test/data/webui/settings/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8375fab221f8da2beff974b9381de8062e0adf0 commit c8375fab221f8da2beff974b9381de8062e0adf0 Author: Patti <patricialor@chromium.org> Date: Thu Jun 14 07:36:52 2018 Settings: All Sites now includes sites with embargoed settings. Origins with only embargoed content settings are currently not included in the All Sites list. Fix. Bug: 835712 Change-Id: Ic413db891753e729f618097cca28c554cc02f1fc Reviewed-on: https://chromium-review.googlesource.com/1090596 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#567182} [modify] https://crrev.com/c8375fab221f8da2beff974b9381de8062e0adf0/chrome/browser/permissions/permission_decision_auto_blocker.h [modify] https://crrev.com/c8375fab221f8da2beff974b9381de8062e0adf0/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/c8375fab221f8da2beff974b9381de8062e0adf0/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2cac39f3c0aca0166794ea935e2244293aa9d4e commit e2cac39f3c0aca0166794ea935e2244293aa9d4e Author: Patti <patricialor@chromium.org> Date: Wed Jun 20 05:55:37 2018 Settings: Content settings can now be reset for a group of origins in All Sites. Add a three-dot / overflow menu to groups of origins in All Sites. This overflow menu allows the entire list of origins to have all their content settings reset in one go. This will be preceded with a confirmation dialog. Manual test - With #enable-site-settings turned on, change a content setting via Page Info > Site settings on both https://permission.site and http://permission.site. Navigate to chrome://settings/content/all and see that both sites are listed under 'permission.site'. Verify there is an overflow menu on this entry and that inside the overflow menu, there is a 'Reset permissions' option. Clicking this should bring up a reset permission dialog and confirming the dialog should remove this entry from All Sites. Bug: 835712, 717468 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 Reviewed-on: https://chromium-review.googlesource.com/1098577 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#568742} [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/app/settings_strings.grdp [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/149bce0d01d769126d07181dd314f8090a21bbbe commit 149bce0d01d769126d07181dd314f8090a21bbbe Author: David Grogan <dgrogan@chromium.org> Date: Wed Jun 20 20:58:00 2018 Revert "Settings: Content settings can now be reset for a group of origins in All Sites." This reverts commit e2cac39f3c0aca0166794ea935e2244293aa9d4e. Reason for revert: https://crbug.com/854785 (CrSettingsSiteEntryTest.All failing on chromium.mac/Mac10.13 Tests (dbg)) TypeError: this.$.menu.getIfExists is not a function at HTMLElement.getOverflowMenu_ (chrome://settings/site_settings/site_entry.js:115:65) at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/site_entry_tests.js:136:25) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48) Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} TBR=dschuyler@chromium.org,patricialor@chromium.org Change-Id: I227ad85a38a66a6f571dab6aabfdfb5211580280 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835712, 717468 , 854785 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1108777 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569007} [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/app/settings_strings.grdp [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/905d2540001fa7379d40426e4d37207f8f7fd1b1 commit 905d2540001fa7379d40426e4d37207f8f7fd1b1 Author: Patti <patricialor@chromium.org> Date: Fri Jun 22 02:23:03 2018 Reland "Settings: Content settings can now be reset for a group of origins in All Sites." This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} Bug: 835712, 717468 Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1109537 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#569507} [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/app/settings_strings.grdp [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe commit b87c9121587d547162b56b5b0c8dfb8a6d1bebbe Author: Peter Williamson <petewil@chromium.org> Date: Fri Jun 22 21:31:09 2018 Revert "Reland "Settings: Content settings can now be reset for a group of origins in All Sites."" This reverts commit 905d2540001fa7379d40426e4d37207f8f7fd1b1. Reason for revert: After landing this patch, CrSettingsSiteEntryTest started failing on Mac 10.13 (dbg) and Win 7(dbg), though it succeeds on other platforms. Flakiness dashboard data here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsSiteEntryTest.All Picking this change as a likely culprit, so we can get the tree back to green everywhere. https://crbug.com/855687 is tracking the issue. Bug: 855687 Original change's description: > Reland "Settings: Content settings can now be reset for a group of origins in All Sites." > > This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e > > Original change's description: > > Settings: Content settings can now be reset for a group of origins in All Sites. > > > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > > menu allows the entire list of origins to have all their content settings reset > > in one go. This will be preceded with a confirmation dialog. > > > > Manual test - With #enable-site-settings turned on, change a content setting via > > Page Info > Site settings on both https://permission.site and > > http://permission.site. Navigate to chrome://settings/content/all and see that > > both sites are listed under 'permission.site'. Verify there is an overflow menu > > on this entry and that inside the overflow menu, there is a 'Reset permissions' > > option. Clicking this should bring up a reset permission dialog and confirming > > the dialog should remove this entry from All Sites. > > > > Bug: 835712, 717468 > > Cq-Include-Trybots: luci.chromium.try:closure_compilation > > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > > Reviewed-on: https://chromium-review.googlesource.com/1098577 > > Commit-Queue: Patti <patricialor@chromium.org> > > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568742} > > Bug: 835712, 717468 > Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/1109537 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569507} TBR=dschuyler@chromium.org,patricialor@chromium.org Change-Id: I18f90cd22046b3d79efae2878aaca822b26bd828 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835712, 717468 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1112122 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#569787} [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/app/settings_strings.grdp [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/site_entry_tests.js
Screenshot of the site representations used in All Sites, connected to crrev.com/c/1107579.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/112407912fd7aab9fb93add99131322a088559e4 commit 112407912fd7aab9fb93add99131322a088559e4 Author: Patti <patricialor@chromium.org> Date: Tue Jun 26 02:50:55 2018 Reland "Settings: Content settings can now be reset for a group of origins in All Sites." This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} Bug: 835712, 717468 Change-Id: I7825326b8fa133d54971180bfd37494b19c5e86c Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1113037 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#570309} [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/app/settings_strings.grdp [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cf209e50a20f7e7993decdc5f2947c755c26b31 commit 0cf209e50a20f7e7993decdc5f2947c755c26b31 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Jun 26 16:41:49 2018 Revert "Reland "Settings: Content settings can now be reset for a group of origins in All Sites."" This reverts commit 112407912fd7aab9fb93add99131322a088559e4. Reason for revert: CrSettingsSiteDetailsTest.All consistently fails on linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg Original change's description: > Reland "Settings: Content settings can now be reset for a group of origins in All Sites." > > This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e > > Original change's description: > > Settings: Content settings can now be reset for a group of origins in All Sites. > > > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > > menu allows the entire list of origins to have all their content settings reset > > in one go. This will be preceded with a confirmation dialog. > > > > Manual test - With #enable-site-settings turned on, change a content setting via > > Page Info > Site settings on both https://permission.site and > > http://permission.site. Navigate to chrome://settings/content/all and see that > > both sites are listed under 'permission.site'. Verify there is an overflow menu > > on this entry and that inside the overflow menu, there is a 'Reset permissions' > > option. Clicking this should bring up a reset permission dialog and confirming > > the dialog should remove this entry from All Sites. > > > > Bug: 835712, 717468 > > Cq-Include-Trybots: luci.chromium.try:closure_compilation > > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > > Reviewed-on: https://chromium-review.googlesource.com/1098577 > > Commit-Queue: Patti <patricialor@chromium.org> > > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568742} > > Bug: 835712, 717468 > Change-Id: I7825326b8fa133d54971180bfd37494b19c5e86c > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/1113037 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570309} TBR=dschuyler@chromium.org,patricialor@chromium.org Change-Id: Ia270a380442ebdd75014034a1ee980341a9b0f1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835712, 717468 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1115179 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570427} [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/app/settings_strings.grdp [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ac19b43a9c276b0169dd263f7cd33f42785c21b commit 3ac19b43a9c276b0169dd263f7cd33f42785c21b Author: Patti <patricialor@chromium.org> Date: Fri Jun 29 04:24:20 2018 Reland "Settings: Content settings can now be reset for a group of origins in All Sites." This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} TBR=stevenjb@chromium.org Bug: 835712, 717468 Change-Id: I88522c41a536e86e27b831358c61842d69f42d34 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1116318 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#571386} [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/app/settings_strings.grdp [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32 commit fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32 Author: Patti <patricialor@chromium.org> Date: Fri Jun 29 06:12:10 2018 Settings: All Sites now shows more user-friendly URLs. Currently, All Sites shows all origins in their raw format, which looks crowded and can be confusing to users. Use the host instead in most situations, displaying non-HTTPS schemes off to the side to easily differentiate from other hosts that may be the same. Note non-default ports will also be shown as part of the host. See a screenshot - https://bugs.chromium.org/p/chromium/issues/detail?id=835712#c12 Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id34ef01e3fe41cd428e5a97bbc4fc207dbe07d05 Reviewed-on: https://chromium-review.googlesource.com/1107579 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#571406} [modify] https://crrev.com/fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32/chrome/app/settings_strings.grdp [modify] https://crrev.com/fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/fc3a2ebf105a03e67ece5cd8efadd61b6cfa7b32/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c5e860408f28d316cbd1d2652dd95e249732810 commit 4c5e860408f28d316cbd1d2652dd95e249732810 Author: Patti <patricialor@chromium.org> Date: Wed Jul 04 03:03:34 2018 Settings: Set active global scroll handler at the end of the execution queue. Currently, the global scroll handler gets set as active immediately when the chrome://settings route changes. However, scroll-handling elements such as iron-list may require access to the global scroll handler during a route change. Fix by setting the global scroll handler active value at the next event loop instead of immediately. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie02843a8d556a5b44a87f4ba696cab2eeff23e70 Reviewed-on: https://chromium-review.googlesource.com/1100659 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#572457} [modify] https://crrev.com/4c5e860408f28d316cbd1d2652dd95e249732810/chrome/browser/resources/settings/global_scroll_target_behavior.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c61a083bfa16fb5c693c86c219981b9c114bda09 commit c61a083bfa16fb5c693c86c219981b9c114bda09 Author: Patti <patricialor@chromium.org> Date: Wed Jul 11 04:37:04 2018 Settings: Client side infinite scrolling in All Sites. An extremely large number of sites may appear in All Sites, so make sure the client doesn't need to render any more site-entries than required at any one time by converting it to use an iron-list. Also introduce a couple other polish fixes, such as scrolling to a site-entry when it's expanded, or scrolling to the same site-entry previously selected (if any) when navigating back to All Sites from a different route. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifca117ac6739aed927ca61efeaadcb9057487f5d Reviewed-on: https://chromium-review.googlesource.com/1116204 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#574073} [modify] https://crrev.com/c61a083bfa16fb5c693c86c219981b9c114bda09/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/c61a083bfa16fb5c693c86c219981b9c114bda09/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/c61a083bfa16fb5c693c86c219981b9c114bda09/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/c61a083bfa16fb5c693c86c219981b9c114bda09/chrome/browser/resources/settings/site_settings/site_entry.js
Screenshot for how the searching and sorting functionality in All Sites will look (note the default search method will not be by name):
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f91ab731bd7194c47e55047e258a48224a88ce3a commit f91ab731bd7194c47e55047e258a48224a88ce3a Author: Patti <patricialor@chromium.org> Date: Fri Jul 13 04:08:05 2018 Settings: Prevent All Sites entries being stuck in an expanded state. r574073 updated the all sites page to use an iron-list, which allows parts of the DOM to be re-used as the user scrolls down the page and loads additional all sites items. However, since the expandable list in each site-entry is stored separately (i.e. not in the iron-list item), this value can get stale when an already expanded entry is re-used in an ungrouped site-entry, resulting in a site-entry with a single origin listed getting stuck in an opened state. To fix, check when the site-entry changes iron-list items and close the expandable list if the iron-list item is ungrouped. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2bb33b60623e2fb12487e730ec122391a1d76660 Reviewed-on: https://chromium-review.googlesource.com/1134644 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#574839} [modify] https://crrev.com/f91ab731bd7194c47e55047e258a48224a88ce3a/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/f91ab731bd7194c47e55047e258a48224a88ce3a/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/f91ab731bd7194c47e55047e258a48224a88ce3a/chrome/test/data/webui/settings/site_entry_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5805a8c8f2736a9b846046b0a10c423be73512f9 commit 5805a8c8f2736a9b846046b0a10c423be73512f9 Author: Patti <patricialor@chromium.org> Date: Fri Jul 13 22:41:50 2018 Settings: Show the number of cookies set on grouped entries in All Sites. Show the number of cookies on a domain / eTLD+1 group of sites in All Sites. Since cookies at their widest scope can be set on eTLD+1s, this display will be restricted to sites that are grouped. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I66d2c36b2af1ad577d4d71512f3d22541e1c926f Reviewed-on: https://chromium-review.googlesource.com/1111770 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575098} [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/app/settings_strings.grdp [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/resources/settings/site_settings/local_data_browser_proxy.js [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/5805a8c8f2736a9b846046b0a10c423be73512f9/chrome/test/data/webui/settings/test_local_data_browser_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32b19c702c2095a98024fa55ef35e680a10656c0 commit 32b19c702c2095a98024fa55ef35e680a10656c0 Author: Patti <patricialor@chromium.org> Date: Sat Jul 14 05:43:28 2018 Settings: All Sites page now has search functionality. Add search function to the All Sites page. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1bfe1ff81a3293962a6263e2a54d38bb06d3d382 Reviewed-on: https://chromium-review.googlesource.com/1126596 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575154} [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/app/settings_strings.grdp [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/32b19c702c2095a98024fa55ef35e680a10656c0/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e4da7a1d557619d919234b2058cc17c04c32d01 commit 7e4da7a1d557619d919234b2058cc17c04c32d01 Author: Patti <patricialor@chromium.org> Date: Sat Jul 14 23:01:52 2018 Settings: All Sites now can sort sites by domain (eTLD+1). Add functionality to sort the All Sites list, with an initial option to sort by a site group's eTLD+1 name. Note that sites shown individually (ungrouped) in All Sites will also be sorted by their eTLD+1. See a screenshot of this feature at https://bugs.chromium.org/p/chromium/issues/detail?id=835712#c19 Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic58e1bf294189b4fefc2cf0f8532725a71f2b36c Reviewed-on: https://chromium-review.googlesource.com/1128782 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#575165} [modify] https://crrev.com/7e4da7a1d557619d919234b2058cc17c04c32d01/chrome/app/settings_strings.grdp [modify] https://crrev.com/7e4da7a1d557619d919234b2058cc17c04c32d01/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/7e4da7a1d557619d919234b2058cc17c04c32d01/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/7e4da7a1d557619d919234b2058cc17c04c32d01/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/7e4da7a1d557619d919234b2058cc17c04c32d01/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/7e4da7a1d557619d919234b2058cc17c04c32d01/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00aa4484f993bfd9c8525f5bb8d075b44f8e023b commit 00aa4484f993bfd9c8525f5bb8d075b44f8e023b Author: Patti <patricialor@chromium.org> Date: Thu Jul 26 04:37:14 2018 Settings: Remember last selected item in All Sites. Currently, if the user chooses an item in the all sites list and is taken to the Site Details page, they will be returned to the top of the all sites page upon pressing the back button. This isn't the best user experience if their all sites page is very long, as they may need to scroll back down to find the site they were originally looking at. To fix, remember the site-entry the user last clicked on and scroll back to that site-entry when returning to all sites. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I552c659408b78698c942fcef71be33783dab6578 Reviewed-on: https://chromium-review.googlesource.com/1136252 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#578204} [modify] https://crrev.com/00aa4484f993bfd9c8525f5bb8d075b44f8e023b/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/00aa4484f993bfd9c8525f5bb8d075b44f8e023b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/00aa4484f993bfd9c8525f5bb8d075b44f8e023b/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/00aa4484f993bfd9c8525f5bb8d075b44f8e023b/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/00aa4484f993bfd9c8525f5bb8d075b44f8e023b/chrome/browser/resources/settings/site_settings/site_entry.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0aabdf0b1239fb9fa916777be95af59c883c9c commit 9b0aabdf0b1239fb9fa916777be95af59c883c9c Author: Patti <patricialor@chromium.org> Date: Tue Jul 31 02:09:00 2018 Settings: All Sites now includes sites using local storage. Currently, the All Sites list only includes sites with non-default content settings. Update it to include sites that use local storage (disk space) as well. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I722c659b551aaf5023bb82a7475151df39a092be Reviewed-on: https://chromium-review.googlesource.com/1137812 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#579276} [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.h [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/9b0aabdf0b1239fb9fa916777be95af59c883c9c/chrome/test/data/webui/settings/all_sites_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e7dda3d051da98464f63a2ac25873685a6a9c44 commit 0e7dda3d051da98464f63a2ac25873685a6a9c44 Author: Patti <patricialor@chromium.org> Date: Tue Jul 31 03:21:11 2018 Settings: All sites can now be sorted by most visited. The default sort order of the All Sites page is by the amount of site engagement each site has. Retrieve the site engagement score for each origin in All Sites and sort the list by the max site engagement per domain (eTLD+1) group. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I421c41f3307a4e5b3ea35683bc4455dfc69ecd96 Reviewed-on: https://chromium-review.googlesource.com/1141667 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579302} [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/app/settings_strings.grdp [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js [modify] https://crrev.com/0e7dda3d051da98464f63a2ac25873685a6a9c44/chrome/test/data/webui/settings/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc61cf968f889468931dc1f3995b53507fa29fc6 commit cc61cf968f889468931dc1f3995b53507fa29fc6 Author: Patti <patricialor@chromium.org> Date: Tue Jul 31 05:04:23 2018 Settings: All sites can now be sorted by data stored (currently, cookies). A primary use case for the All Sites page should be to view the sites that are using the most disk space on the user's device. Implement this in this patch with support for sorting via the number of cookies (descending), with local and website storage to come later. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia8ea3f75d1d102956bf31f9d409e642d47698aca Reviewed-on: https://chromium-review.googlesource.com/1146534 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579315} [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/app/settings_strings.grdp [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/resources/settings/site_settings/local_data_browser_proxy.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/test/data/webui/settings/test_local_data_browser_proxy.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js [modify] https://crrev.com/cc61cf968f889468931dc1f3995b53507fa29fc6/chrome/test/data/webui/settings/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f commit ac6abd59d612fd5152719dcb2ee9625e0d8ad11f Author: Patti <patricialor@chromium.org> Date: Tue Jul 31 06:32:40 2018 Settings: All Sites now shows (and sorts by) local storage per origins. A primary use case for the All sites page should be to view the sites that are using the most disk space on the user’s device. Currently grouped sites show the number of cookies. This patch adds support for showing the amount of local storage used for each origin. Sorting by data usage in all sites will now sort by local storage, using the number of cookies as a tie breaker, i.e. sites with any amount of local storage will be ordered before sites with no local storage and cookies. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3816279f9795fbaa59d67279548a1deba097f852 Bug: 835712 Reviewed-on: https://chromium-review.googlesource.com/1148169 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#579328} [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js [modify] https://crrev.com/ac6abd59d612fd5152719dcb2ee9625e0d8ad11f/chrome/test/data/webui/settings/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ca4fd095adc2cd1fa283d372a8abe030f21c5a3 commit 0ca4fd095adc2cd1fa283d372a8abe030f21c5a3 Author: Maggie Cai <mxcai@chromium.org> Date: Mon Jan 07 02:20:03 2019 Settings: Update empty state for All Sites page. Currently nothing will be shown when the all sites list is empty. This CL adds explanation text for not showing a list of sites. Bug: 835712 Change-Id: Ib34f50a97a7b254423adbbca086d5ae69cc9542a Reviewed-on: https://chromium-review.googlesource.com/c/1391655 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#620242} [modify] https://crrev.com/0ca4fd095adc2cd1fa283d372a8abe030f21c5a3/chrome/app/settings_strings.grdp [modify] https://crrev.com/0ca4fd095adc2cd1fa283d372a8abe030f21c5a3/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/0ca4fd095adc2cd1fa283d372a8abe030f21c5a3/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/0ca4fd095adc2cd1fa283d372a8abe030f21c5a3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07e815b4c6b81a30709814cb11f2782357cfa413 commit 07e815b4c6b81a30709814cb11f2782357cfa413 Author: Maggie Cai <mxcai@chromium.org> Date: Tue Jan 08 02:30:46 2019 Settings: All Sites now includes sites using web storage. Currently, the All Sites list only includes sites with non-default content settings or a non-zero amount of local storage. Update it to include sites that uses web storage and sites with cookies as well. This CL: - Updates to show the web storage for each eTLD+1 and origin on All Sites page. - Sorting by data usage in all sites will now sort by web storage. - Origin and eTLD+1 with cookies but no web storage will be shown. - Show cookies for non grouped sites and for origins that has cookies. - Sites with same host will shown as one origin. Because cookies don't have scheme, so the origins with only cookies will show as http regardless the actual scheme, however, for origins that has permissions or data, the cookie info will be updated in the existing origins. BUG=835712 Change-Id: I7bb9532d0362190d8b70946316ac2f48a3fe442b Reviewed-on: https://chromium-review.googlesource.com/c/1369551 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#620588} [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/browsing_data/cookies_tree_model.cc [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/browsing_data/cookies_tree_model.h [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/resources/settings/site_settings/local_data_browser_proxy.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/test/data/webui/settings/test_local_data_browser_proxy.js [modify] https://crrev.com/07e815b4c6b81a30709814cb11f2782357cfa413/chrome/test/data/webui/settings/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/009ce55d31b2f0d063ebcda0f911dd728e565cb8 commit 009ce55d31b2f0d063ebcda0f911dd728e565cb8 Author: Maggie Cai <mxcai@chromium.org> Date: Tue Jan 08 04:28:47 2019 Settings: Add unit tests for fetching storage and cookies. This CL adds a unit test for storage and cookie data fetching and sending. BUG=835712 Change-Id: I49e9198c0a404c5800a05dcd701173c88564c0e8 Reviewed-on: https://chromium-review.googlesource.com/c/1385700 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#620618} [modify] https://crrev.com/009ce55d31b2f0d063ebcda0f911dd728e565cb8/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/009ce55d31b2f0d063ebcda0f911dd728e565cb8/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/009ce55d31b2f0d063ebcda0f911dd728e565cb8/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
Issue 269298 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/397d692aff6968994cab84da166cefd114bed853 commit 397d692aff6968994cab84da166cefd114bed853 Author: Maggie Cai <mxcai@chromium.org> Date: Wed Jan 16 02:03:14 2019 Settings: Allow user to clear data for etld+1 on All Sites page. This CL: - Add new button for grouped sites to clear data and cookies on the All Sites Page. - Add confirmation dialog for clearing data and cookies. - Clear the data through cookies tree model. - Updates the display automatically when user reset the permissions or clear the data from the All Sites page. - Unit tests will be added in the following CL. Bug: 835712 Change-Id: I8cdfc57ee44b0c106f2fa410abd54b0a25fa260c Reviewed-on: https://chromium-review.googlesource.com/c/1404218 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#623023} [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/app/settings_strings.grdp [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/resources/settings/site_settings/all_sites.js [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/resources/settings/site_settings/site_entry.html [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/resources/settings/site_settings/site_entry.js [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/ui/webui/settings/site_settings_handler.cc [modify] https://crrev.com/397d692aff6968994cab84da166cefd114bed853/chrome/browser/ui/webui/settings/site_settings_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3de729c5d736007196ce58fe6e259b9edecd2f27 commit 3de729c5d736007196ce58fe6e259b9edecd2f27 Author: Maggie Cai <mxcai@chromium.org> Date: Fri Jan 18 02:15:24 2019 Settings: Add tests for delete web storage data and cookies for ETLD+1. This CL adds unit tests and browser tests for clearing data from overflow menu. And updates unit tests for reset settings from overflow menu. BUG=835712 Change-Id: I39521bd4bfed33ab8aa20f81d29253ceeec8c180 Reviewed-on: https://chromium-review.googlesource.com/c/1410442 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#623959} [modify] https://crrev.com/3de729c5d736007196ce58fe6e259b9edecd2f27/chrome/browser/ui/webui/settings/site_settings_handler.h [modify] https://crrev.com/3de729c5d736007196ce58fe6e259b9edecd2f27/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc [modify] https://crrev.com/3de729c5d736007196ce58fe6e259b9edecd2f27/chrome/test/data/webui/settings/site_entry_tests.js [modify] https://crrev.com/3de729c5d736007196ce58fe6e259b9edecd2f27/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js [modify] https://crrev.com/3de729c5d736007196ce58fe6e259b9edecd2f27/chrome/test/data/webui/settings/test_util.js
Comment 1 by bugdroid1@chromium.org
, Apr 27 2018