void DirectoryLoader::ReadDirectory( const base::FilePath& directory_path, const ReadDirectoryEntriesCallback& entries_callback, const FileOperationCallback& completion_callback) { Needs code if the root is a team drive to read from that team drive.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24e4ff543fc3d823fdf1e88376f2ab60e6193edb commit 24e4ff543fc3d823fdf1e88376f2ab60e6193edb Author: Stuart Langley <slangley@chromium.org> Date: Fri May 25 00:29:19 2018 Add an abstraction to get the root_folder_id from change list loading. Currently change list loader and directory loader use AboutResourceLoader to get the root folder id. However, with team drives the root folder id is a constant (the team drive id) and we need a way to supply this value when the change list loader and directory loader are loading changelists for team drives. The RootFolderIdLoader pure virtual class allows us to provide an abstraction for reading the root folder id either from AboutResource or a constant string. Bug: 835703 , 715355 Change-Id: I7d0766c5f813353186d3fbd3f6b20219c809eb4e Reviewed-on: https://chromium-review.googlesource.com/1068527 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561706} [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/BUILD.gn [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/change_list_loader_unittest.cc [add] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/about_resource_root_folder_id_loader.cc [add] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/about_resource_root_folder_id_loader.h [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/change_list_loader.cc [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/change_list_loader.h [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/default_corpus_change_list_loader.cc [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/default_corpus_change_list_loader.h [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/directory_loader.cc [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/directory_loader.h [add] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/chromeos/root_folder_id_loader.h [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/directory_loader_unittest.cc [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/file_system/operation_test_base.cc [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/file_system/operation_test_base.h [modify] https://crrev.com/24e4ff543fc3d823fdf1e88376f2ab60e6193edb/components/drive/sync_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95c215051866fcfdcfb2d7705a61b33e5197df4e commit 95c215051866fcfdcfb2d7705a61b33e5197df4e Author: Stuart Langley <slangley@chromium.org> Date: Fri May 25 04:21:29 2018 Pass the team drive id and root path to loaders so the can support team drives. Currently change_list_loader and directory_loader only work for the users default corpus. We can fix this by passing the team_drive_id and the root_entry_path as parameters during construction rather then just assuming the users default corpus root. With this change we can not use directory_loader and change_list_loader to also processes changes from team drives by passing the appropriate team_drive_id and root_entry_path. Bug: 835703 , 833690 Change-Id: I5ba3ed8fa3323dfd520c9e1837934eeef79a30a7 Reviewed-on: https://chromium-review.googlesource.com/1068642 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561767} [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/change_list_loader_unittest.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/change_list_processor_unittest.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/change_list_loader.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/change_list_loader.h [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/change_list_processor.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/change_list_processor.h [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/default_corpus_change_list_loader.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/directory_loader.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/chromeos/directory_loader.h [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/directory_loader_unittest.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/file_system/operation_test_base.cc [modify] https://crrev.com/95c215051866fcfdcfb2d7705a61b33e5197df4e/components/drive/sync_client_unittest.cc
Comment 1 by sashab@chromium.org
, May 10 2018