New issue
Advanced search Search tips

Issue 835701 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Debug version crashes at Xiaomi/Huawei phones with 4G.

Project Member Reported by pengcheng@google.com, Apr 23 2018

Issue description

Chrome Version: 68.0.3404.0
OS: Android 8.0.0; BLA-AL00 Build/HUAWEIBLA-AL00

What steps will reproduce the problem?
(1) Turn off wifi and enable 4G (with full signal)
(2) Build a debug Chromium apk.
(3) Install and open app.

What is the expected result?
Not crash.

What happens instead?
Crashed


Crash Stack:
----------------------------------------------------------------------
04-23 12:01:12.538 3831-3895/com.google.android.apps.chrome A/chromium: [FATAL:cellular_signal_strength.cc(40)] Check failed: 4 >= signal_strength_level (4 vs. 5)
#00 0xc84e7309 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000ce309
#01 0xc6c9fc49 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x002d8c49
#02 0xc6d3e0dd /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x003770dd
#03 0xc6d3e15f /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x0037715f
#04 0xc6d3c699 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x00375699
#05 0xc6d3cd91 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x00375d91
#06 0xc6d3c0cd /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x003750cd
#07 0xc6d3bc91 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x00374c91
#08 0xc6d40225 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x00379225
#09 0xc6d40209 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x00379209
#10 0xc6d401f5 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x003791f5
#11 0xc6d43e89 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libnet.cr.so+0x0037ce89
#12 0xc84d28b9 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000b98b9
#13 0xc84db03f /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000c203f
#14 0xc84eb7a9 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000d27a9
#15 0xc84ed189 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000d4189
#16 0xc84ed38f /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000d438f
#17 0xc84ed45d /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000d445d
#18 0xc85485ad /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x0012f5ad
#19 0xc84ecf53 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000d3f53
#20 0xc8501427 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x000e8427
#21 0xc851d03d /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x0010403d
#22 0xbd64e34b /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libcontent.cr.so+0x00b6b34b
#23 0xbd64e319 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libcontent.cr.so+0x00b6b319
#24 0xc851d2a3 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x001042a3
#25 0xc8541c87 /data/app/com.google.android.apps.chrome-hXksVKQtfdz8Cdt7oylQog==/lib/arm/libbase.cr.so+0x00128c87
#26 0xeb6ac64f /system/lib/libc.so+0x0004864f
#27 0xeb67f02f /system/lib/libc.so+0x0001b02f
04-23 12:01:12.539 3831-3895/com.google.android.apps.chrome A/libc: Fatal signal 6 (SIGABRT), code -6 in tid 3895 (Chrome_IOThread)

From the code (https://cs.chromium.org/chromium/src/net/android/cellular_signal_strength.cc?q=cellular_signal_strength.cc&sq=package:chromium&dr&l=40), there is a DCHECK that checks signal level must <= 4, from Android doc, the range of signal level is 0-4, but some OEM phones in China (confirmed Huawei Mate10 Pro and Xiaomi Mix2), the customized the definition of signal level to 0-5, it may crash the app when signal is full (5).
 
Cc: tbansal@chromium.org
Components: Internals>Network
tbansal@ can you take a look or help triage?  Thanks!
Owner: tbansal@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-2 M-68 Pri-1
Status: Started (was: Assigned)
Components: -Internals>Network Internals>Network>NetworkQuality
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ceb20aa2d291781ab6b0c9a2b0c3a2f44cf0581

commit 7ceb20aa2d291781ab6b0c9a2b0c3a2f44cf0581
Author: Tarun Bansal <tbansal@chromium.org>
Date: Thu Apr 26 22:18:32 2018

Cap the cellular signal strength level to be between 0 and 4
(both inclusive).

Bug:  835701 
Change-Id: I93f2aeed4bd615e5380f6d877479df0a46367f3d
Reviewed-on: https://chromium-review.googlesource.com/1031172
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554167}
[modify] https://crrev.com/7ceb20aa2d291781ab6b0c9a2b0c3a2f44cf0581/net/android/cellular_signal_strength.cc
[modify] https://crrev.com/7ceb20aa2d291781ab6b0c9a2b0c3a2f44cf0581/net/android/cellular_signal_strength.h

Status: Fixed (was: Started)

Sign in to add a comment