DepsCache entry is short |
||
Issue descriptionThe default entry size is 35000, however, it is short these days. From the current main waterfall, Android: hit=33613 updated=10 missed=0 total=33623 Linux: hit=35037 updated=11 missed=9977 total=45025 Mac: hit=35015 updated=14 missed=7808 total=42837 Win: hit=35006 updated=23 missed=18345 total=53374 Win x64: hit=35005 updated=18 missed=7865 total=37888 So we need 55000 at least. Maybe better to have 60000 by default? Currently DepsCache entries are loaded in non main thread, using larger entries won't cause goma-start up problem. The only risky thing I come up with is to exceed the total .proto size. If it exceeds 128MB, we discard it. However, though goma canary's localoutputcache builder have 70000 entries, the total size fits in 128MB. So, it should be ok.
,
Apr 23 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/goma/client/+/b2f955cddd14335bef057f38e47180f8551c8619 commit b2f955cddd14335bef057f38e47180f8551c8619 Author: Shinya Kawanaka <shinyak@google.com> Date: Mon Apr 23 09:46:01 2018
,
May 10 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 23 2018