Responsive - increase by a 100 (CMD+up/down arrow) focuses the DOM tree
Reported by
emiljoha...@gmail.com,
Apr 22 2018
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36 Steps to reproduce the problem: 1. Select the Elements tab 2. Toggle device toolbar and select the Responsive view 3. Focus the width field 4. Hold CMD and press arrow up What is the expected behavior? I expect to stay within the field and be able to increase or decrease the size of the window. Instead it increases it by a 100 and then focuses the DOM tree, making me move around the current focused element. What went wrong? The DOM tree is focused. Did this work before? Yes Chrome version: 66.0.3359.117 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Apr 22 2018
,
Apr 23 2018
Able to reproduce the issue on reported chrome version 66.0.3359.117 and latest chrome 68.0.3403.0 using Windows-10, Mac 10.12.6 & Ubuntu 17.10 hence providing Bisect Info Bisect Info: ================ Good build: 65.0.3323.0 Bad build: 65.0.3324.0 You are probably looking for a change made after 530005 (known good), but no later than 530006 (first known bad). https://chromium.googlesource.com/chromium/src/+log/0df2f5441276d78d86a5936f3640f34374cc89d6..ed9388054c24171adc1c1ac5e9795f1832e8f179 Reviewed-on: https://chromium-review.googlesource.com/871841 @Pavel Feldman: Please confirm the issue and help in re-assigning if it is not related to your change. Thanks!
,
Apr 30 2018
Since this is a recent regression and also have a clear suspect. Please have a fix during M68 time frame.
,
May 4 2018
,
May 7 2018
*** Bulk Edit *** M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec3529b434fdde061f924b8e3a93f4f1a386f8c6 commit ec3529b434fdde061f924b8e3a93f4f1a386f8c6 Author: Pavel Feldman <pfeldman@chromium.org> Date: Mon May 07 20:41:34 2018 DevTools: do not handle active panel shortcuts unless panel has focus. Bug: 835656 Change-Id: I9b0692917facb673fc01c9974430d1e66fcd7742 Reviewed-on: https://chromium-review.googlesource.com/1048031 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556559} [modify] https://crrev.com/ec3529b434fdde061f924b8e3a93f4f1a386f8c6/third_party/blink/renderer/devtools/front_end/main/Main.js
,
May 8 2018
Able to reproduce the issue on chrome reported version 66.0.3359.117 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #68.0.3424.0 as per the comment#0 Attaching screen cast for reference. Observed "Focus stays within the field and able to increase/decrease the size of the window" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
May 9 2018
,
May 9 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2018
pfeldman@, how safe & critical is the change listed at #7 to merge to M67? This is regressed in M66 stable which is already out at 100% so wanted to double check.
,
May 9 2018
This is very much safe to merge. Was caught late, but still makes sense for M67. Works in Canary fine now.
,
May 9 2018
Approving merge to M67 branch 3396 based on comment #8 and #12. Thank you.
,
May 9 2018
Also pls mark bug as fixed after M67 merge if nothing else is pending. Thank you.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eedb48fb426b8cea6f9e478704505c59cbb8b9a commit 0eedb48fb426b8cea6f9e478704505c59cbb8b9a Author: Pavel Feldman <pfeldman@chromium.org> Date: Thu May 10 18:39:08 2018 DevTools: do not handle active panel shortcuts unless panel has focus. TBR=pfeldman@chromium.org (cherry picked from commit ec3529b434fdde061f924b8e3a93f4f1a386f8c6) Bug: 835656 Change-Id: I9b0692917facb673fc01c9974430d1e66fcd7742 Reviewed-on: https://chromium-review.googlesource.com/1048031 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556559} Reviewed-on: https://chromium-review.googlesource.com/1054257 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#550} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/0eedb48fb426b8cea6f9e478704505c59cbb8b9a/third_party/blink/renderer/devtools/front_end/main/Main.js
,
May 10 2018
,
May 16 2018
Able to reproduce the issue on chrome reported version 66.0.3359.117 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #67.0.3396.48 as per the comment#0 Attaching screen cast for reference. Observed "Focus stays within the field and able to increase/decrease the size of the window" Hence, the fix is working as expected. Adding the verified label. Thanks! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by emiljoha...@gmail.com
, Apr 22 20182.6 MB
2.6 MB View Download