New issue
Advanced search Search tips

Issue 835652 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 825134
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Daylight Savings for Australia East Coast are wrong for one week before DST onset date change

Reported by ja...@questmetrics.com, Apr 22 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce the problem:
Set locale to Australia, Sydney
[new Date(953996400000), new Date(954000000000), new Date(954003600000)]

What is the expected behavior?
Sun Mar 26 2000 02:00:00 GMT+1100 (Local Daylight Time)
Sun Mar 26 2000 02:00:00 GMT+1000 (Local Standard Time)
Sun Mar 26 2000 03:00:00 GMT+1000 (Local Standard Time)

What went wrong?
DST transitions are recorded as being one week later than actual, so times are incorrect for 14 days each year.
IE and Firefox report values correctly.

Did this work before? N/A 

Chrome version: 66.0.3359.117  Channel: stable
OS Version: 10.0
Flash Version:
 
Oops, forgot actual output:
Sun Mar 26 2000 02:00:00 GMT+1100 (Local Daylight Time) {}
Sun Mar 26 2000 03:00:00 GMT+1100 (Local Daylight Time) {}
Sun Mar 26 2000 04:00:00 GMT+1100 (Local Daylight Time) {}

Labels: Needs-Triage-M66
Components: -Blink Blink>JavaScript>Internationalization
Labels: -Type-Bug -Pri-2 hasbisect-per-revision ReleaseBlock-Stable Triaged-ET M-66 FoundIn-66 Target-66 OS-Linux Pri-1 Type-Bug-Regression
Owner: js...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Win-10 and Ubuntu 14.04 using chrome reported version #66.0.3359.117 but the same is not reproducible in the latest canary #68.0.3404.0.

Reverse Bisect Information:
=====================
Good build: 67.0.3366.0
Bad Build : 67.0.3365.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/36c7581411a133a52e8b73534765aab824a2d1eb..43db8c3666e41c337498ae066f0a2c012f888350

v8-autoroll CL:
https://chromium.googlesource.com/v8/v8/+log/1666d944..16d3f07a

From the above change log suspecting below change
Change-Id: I22203670c3307a57fbf99e5f0a271dcbfbbef8fd
Reviewed-on: https://chromium-review.googlesource.com/857333

jshin@ - Could you please check and merge the fix to M-66 if it is a valid candidate.
Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!

Comment 4 by js...@chromium.org, Apr 24 2018

Labels: -Pri-1 Pri-2
Mergedinto: 825134
Status: Duplicate (was: Assigned)
This was fixed in 67. Will not be fixed in 66. 

In 66, the following command line flag will fix this issue:

--js-flags="--icu-timezone-data"


Comment 5 by js...@chromium.org, Apr 24 2018

Labels: -OS-Linux -ReleaseBlock-Stable -M-66 -Target-66
Summary: Daylight Savings for Australia East Coast are wrong for one week before DST onset date change (was: Daylight Savings for Australia East Coast are wrong for one week)
krajshree@:  how did you reproduce it on Ubuntu? 

On Linux with timezone set to Austrailia/Sydney, this issue is not present even in 66 (without icu-timezone-data). See below. This is Windows-only issue.

On Ubuntu, you need to do this to change the timezone:  
$ sudo timedatectl set-timezone Australia/Sydney

(you don't need to restart Chrome). In JS console (DOM inspector) of Chrome , try these: 

> new Date(2000,2,25,4)
Sat Mar 25 2000 04:00:00 GMT+1100 (AEDT)
> new Date(2000,2,26,1)
Sat Mar 27 2000 01:00:00 GMT+1100 (AEDT)
> new Date(2000,2,26,4)
Sun Mar 26 2000 04:00:00 GMT+1000 (AEST)
> new Date(2000,3,2,4)
Sun Apr 02 2000 04:00:00 GMT+1000 (AEST)

> [new Date(953996400000), new Date(954000000000), new Date(954003600000)]
(3) [Sun Mar 26 2000 02:00:00 GMT+1100 (AEDT), Sun Mar 26 2000 02:00:00 GMT+1000 (AEST), Sun Mar 26 2000 03:00:00 GMT+1000 (AEST)]

 

Comment 6 by js...@chromium.org, Apr 24 2018

Labels: -Needs-Triage-M66

Sign in to add a comment