New issue
Advanced search Search tips

Issue 835615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Media Controls: overflow menu steals keyboard controls

Project Member Reported by mlamouri@chromium.org, Apr 22 2018

Issue description

Many shortcuts do not work inside the menu such as Ctrl+Shift+i for the dev tools.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/682a3df7a2c8046066f265956b9adcd900e9bbfe

commit 682a3df7a2c8046066f265956b9adcd900e9bbfe
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Apr 23 16:09:00 2018

Media Controls: only eat keyboard inputs on popups when using them.

This allows shortcuts such as going to the dev tools to work while the
popup menus are visible.

Bug:  835615 
Change-Id: Ie09bbe679c1356249138cf45c1b24977f7895158
Reviewed-on: https://chromium-review.googlesource.com/1023596
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552719}
[modify] https://crrev.com/682a3df7a2c8046066f265956b9adcd900e9bbfe/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc

Labels: Merge-Request-67
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Apr 24 2018

Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Beta release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3f2ebadeda2251b27c568cc9b52e6b03562ece4

commit f3f2ebadeda2251b27c568cc9b52e6b03562ece4
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Apr 25 01:00:36 2018

Media Controls: only eat keyboard inputs on popups when using them.

This allows shortcuts such as going to the dev tools to work while the
popup menus are visible.

Bug:  835615 
Change-Id: Ie09bbe679c1356249138cf45c1b24977f7895158
Reviewed-on: https://chromium-review.googlesource.com/1023596
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552719}(cherry picked from commit 682a3df7a2c8046066f265956b9adcd900e9bbfe)
Reviewed-on: https://chromium-review.googlesource.com/1026912
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#279}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/f3f2ebadeda2251b27c568cc9b52e6b03562ece4/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M67 TE-Verified-67.0.3396.30
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #67.0.3396.30 as per the comment #0.
Attaching screen cast for reference.
Observed that chrome opened Devtools upon hitting Cmd+Opt+I (In Mac ), Ctrl+Shift+I (In Windows and Ubuntu)
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!

835615 CL Verif.webm
4.0 MB View Download

Sign in to add a comment