New issue
Advanced search Search tips

Issue 835602 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in blink::ColorSpaceUtilities::GetColorSpaceGamut

Project Member Reported by ClusterFuzz, Apr 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5726553691127808

Fuzzer: libFuzzer_blink_png_decoder_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::ColorSpaceUtilities::GetColorSpaceGamut
  blink::BitmapImageMetrics::CountImageGammaAndGamut
  blink::ImageDecoder::DecodeFrameBufferAtIndex
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=552556:552571

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5726553691127808

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 21 2018

Components: Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 21 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5 ([SPv175] Repaint non-composited layer on layer visibility change).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>Paint
Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 22 2018

Labels: M-67
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 22 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 22 2018

Labels: Pri-1

Comment 7 by vakh@chromium.org, Apr 22 2018

Cc: zakerinasab@chromium.org brianosman@chromium.org
Components: Blink>Canvas
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)

Comment 8 by vakh@chromium.org, Apr 22 2018

Cc: -brianosman@chromium.org
Cc: -zakerinasab@chromium.org
Owner: brianosman@chromium.org
r552559 is in the culprit range
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 23 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Cc: mtklein@chromium.org
Looking at the code that's failing, pretty sure https://skia-review.googlesource.com/c/skcms/+/122951 will fix this one, too.
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 14 by ClusterFuzz, Apr 25 2018

ClusterFuzz has detected this issue as fixed in range 553087:553094.

Detailed report: https://clusterfuzz.com/testcase?key=5726553691127808

Fuzzer: libFuzzer_blink_png_decoder_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::ColorSpaceUtilities::GetColorSpaceGamut
  blink::BitmapImageMetrics::CountImageGammaAndGamut
  blink::ImageDecoder::DecodeFrameBufferAtIndex
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=552556:552571
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=553087:553094

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5726553691127808

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by ClusterFuzz, Apr 25 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5726553691127808 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -ReleaseBlock-Stable -M-67 M-68
Project Member

Comment 17 by sheriffbot@chromium.org, Jul 31

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment