New issue
Advanced search Search tips

Issue 835578 link

Starred by 1 user
Status: Duplicate
Merged: issue 835577
Owner:
lukasza@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: SessionRestoreTest.RestoreForeignSession



Sign in to add a comment

SessionRestoreTest.RestoreForeignSession is Flaky

Project Member Reported by Findit, Apr 21 2018 
Findit has detected a flake at test SessionRestoreTest.RestoreForeignSession.

Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Ie87e48658864203d33d1ae647fb2d98a7c488765
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJyY2hyb21pdW0ubWVtb3J5L01hYyBBU2FuIDY0IFRlc3RzICgxKS80MDE3Ni9icm93c2VyX3Rlc3RzL1UyVnpjMmx2YmxKbGMzUnZjbVZVWlhOMExsSmxjM1J2Y21WR2IzSmxhV2R1VTJWemMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
Project Member

Comment 1 by Findit, Apr 21 2018 

Findit identified the culprit r552589 with confidence 70.0% in the config "chromium.memory / Mac ASan 64 Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJyY2hyb21pdW0ubWVtb3J5L01hYyBBU2FuIDY0IFRlc3RzICgxKS80MDE3Ni9icm93c2VyX3Rlc3RzL1UyVnpjMmx2YmxKbGMzUnZjbVZVWlhOMExsSmxjM1J2Y21WR2IzSmxhV2R1VTJWemMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 2 by yoichio@chromium.org, Apr 23 2018

Labels: -Sheriff-Chromium
Owner: lukasza@chromium.org

Comment 3 by lukasza@chromium.org, Apr 23 2018

Mergedinto: 835577
Status: Duplicate (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4572fe082970e7106968514059358385f0d60b58

commit 4572fe082970e7106968514059358385f0d60b58
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Apr 24 01:42:45 2018

Disable tests that flakily repro a UaF when run with --site-per-process.

Bug:  835577 ,  835578 
Change-Id: I4461cec21b31ee9945afe4e2b1df7c89d9905168
Reviewed-on: https://chromium-review.googlesource.com/1024401
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552949}
[modify] https://crrev.com/4572fe082970e7106968514059358385f0d60b58/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/4572fe082970e7106968514059358385f0d60b58/chrome/browser/sessions/tab_restore_browsertest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, May 1 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a556e346add4a254d4affc0584adcf46a37c0fd8

commit a556e346add4a254d4affc0584adcf46a37c0fd8
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue May 01 17:17:50 2018

Disable tests that flakily repro a UaF when run with --site-per-process.

Bug:  835577 ,  835578 
Change-Id: I4461cec21b31ee9945afe4e2b1df7c89d9905168
Reviewed-on: https://chromium-review.googlesource.com/1024401
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552949}(cherry picked from commit 4572fe082970e7106968514059358385f0d60b58)
Reviewed-on: https://chromium-review.googlesource.com/1037603
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#408}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/a556e346add4a254d4affc0584adcf46a37c0fd8/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/a556e346add4a254d4affc0584adcf46a37c0fd8/chrome/browser/sessions/tab_restore_browsertest.cc
►

Sign in to add a comment