New issue
Advanced search Search tips

Issue 835570 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Implement DocumentAndElementEventHandlers

Project Member Reported by pdr@chromium.org, Apr 21 2018

Issue description

There is a new interface in town: DocumentAndElementEventHandlers
https://www.w3.org/TR/html5/single-page.html#documentandelementeventhandlers

[NoInterfaceObject]
interface DocumentAndElementEventHandlers {
  attribute EventHandler oncopy;
  attribute EventHandler oncut;
  attribute EventHandler onpaste;
};

We currently implement these on Element and Document separately.

If I understand the spec correctly, this means the following changes:
1) Add DocumentAndElementEventHandlers [1]
2) Remove oncopy, oncut, and onpaste from Element
3) Make HTMLElement include DocumentAndElementEventHandlers [2]
4) Make SVGElement include DocumentAndElementEventHandlers [3]

[1] https://www.w3.org/TR/html5/single-page.html#documentandelementeventhandlers
[2] https://www.w3.org/TR/html5/single-page.html#htmlelement
[3] https://github.com/w3c/svgwg/pull/413
 
There's now a WPT test for this:

external/wpt/svg/types/scripted/event-handler-all-document-element-events.svg
Owner: eui-sang.lim@samsung.com
Status: Started (was: Available)
I would like to take this issue. 
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce553b6022a43cc4f9744de69ef85a753f47624

commit bce553b6022a43cc4f9744de69ef85a753f47624
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Tue Oct 02 00:07:51 2018

Implement DocumentAndElementEventHandlers

Add DocumentAndElementEventHandlers as per the spec[1] and remove
oncopy, oncut, and onpaste from Document and Element.

[1]: https://w3c.github.io/html/single-page.html#documentandelementeventhandlers

Make Document, HTMLElement, and SVGElement include DocumentAndElementEventHandlers.

Bug:  835570 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie81d7995dbe0824ad3a66ccbfabcdbe5e3864fa4
Reviewed-on: https://chromium-review.googlesource.com/1253169
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#595652}
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.https_exclude=(Document_Window_HTML._)-expected.txt
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.https_include=HTML._-expected.txt
[delete] https://crrev.com/9ee32f1efa92c4baac2f896aab79302fc241feb0/third_party/WebKit/LayoutTests/external/wpt/svg/types/scripted/event-handler-all-document-element-events-expected.txt
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/BUILD.gn
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/document.idl
[add] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/document_and_element_event_handlers.h
[add] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/document_and_element_event_handlers.idl
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/dom/element.idl
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/html/html_element.idl
[modify] https://crrev.com/bce553b6022a43cc4f9744de69ef85a753f47624/third_party/blink/renderer/core/svg/svg_element.idl

Status: Fixed (was: Started)

Sign in to add a comment