New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835561 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Null-dereference READ in SkConvertPixels

Project Member Reported by ClusterFuzz, Apr 21 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5028445327982592

Fuzzer: noel-image-flip
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkConvertPixels
  SkPixmap::readPixels
  blink::DecodingImageGenerator::GetPixels
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=552558:552561

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5028445327982592

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 21 2018

Components: Blink>Paint Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 21 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/371ffcdbb5dca7fb1a0aeb53956905bb1d4f9fc5 ([SPv175] Repaint non-composited layer on layer visibility change).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>Paint -Internals>Skia
Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
Project Member

Comment 4 by ClusterFuzz, Apr 23 2018

Labels: OS-Windows
Cc: brajkumar@chromium.org
Components: Internals>Compositing
Labels: -Type-Bug M-68 Type-Bug-Regression
Owner: mtklein@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "SkPixmap.cpp" suspecting the below Cl might have caused this issue

Suspect CL: https://skia.googlesource.com/skia.git/+/18e9ba1eddb09bff6083f9a83dc569d3b3b54fe6

mtklein@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Owner: ----
Hmm.  Probably not that change.  It doesn't appear that the crash stack is related to SkPixmap::erase(), and I don't think there's any use of 888x, 101010x, or 1010102 in Chromium.
Project Member

Comment 7 by ClusterFuzz, May 8 2018

ClusterFuzz has detected this issue as fixed in range 556606:556608.

Detailed report: https://clusterfuzz.com/testcase?key=5028445327982592

Fuzzer: noel-image-flip
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkConvertPixels
  SkPixmap::readPixels
  blink::DecodingImageGenerator::GetPixels
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=552558:552561
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=556606:556608

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5028445327982592

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, May 8 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5028445327982592 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment