factory: stop when chromeos_shutdown doesn't unmount filesystem clearly? |
|||
Issue descriptionShould we check if chromeos_shutdown did properly unmount all filesystem it cares about during running 'shutdown' pytest and/or Goofy starts? It might be very useful if we can stop the shutdown process and let developers take the chance to analyze what happened. (Or we can make it an option for shutdown pytest.) Besides, it seems like chromeos_shutdown might fail to create the log file '/mnt/stateful_partition/shutdown_stateful_umount_failure'. And the reason is /mnt/stateful_partition became readonly (probably caused by chromeos_shutdown itself...).
,
Sep 7
Assign to fshao as good-first-bug.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/01cb2d8522f3b1f872aea7e8a0b3e6cbbd86c24e commit 01cb2d8522f3b1f872aea7e8a0b3e6cbbd86c24e Author: Fei Shao <fshao@google.com> Date: Wed Sep 26 17:32:44 2018 init: Update unmount logic in chromeos_shutdown Some modifications to ensure /mnt/stateful_partition won't be unmounted if any of the previous unmounts failed, so that system can write failure log into it. Note that mounts like /var, /home, /usr/local are submounts of /mnt/stateful_partition on regular images, so original logic works. But on factory images, they can be independent from /mnt/stateful_partition and system may fail to log because of it. BUG= chromium:835557 TEST=Manually tested on DUT. Change-Id: I73b97e390e5a0110aae2bc691ed3293cf60bfc3e Reviewed-on: https://chromium-review.googlesource.com/1227868 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Fei Shao <fshao@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/01cb2d8522f3b1f872aea7e8a0b3e6cbbd86c24e/init/chromeos_shutdown
,
Sep 27
The bug of failing to create log files should be fixed by the CL above. Regarding youcheng's first concern, instead of stopping shutdown process, one can enable "check_tag_file" flag for shutdown test (refer to /pytests/shutdown.py) and check failure logs after reboot. |
|||
►
Sign in to add a comment |
|||
Comment 1 by briannorris@chromium.org
, Apr 23 2018