Issue 835541 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Apr 2018
Cc:	ellyjo...@chromium.org mac-bugs-priority@chromium.org
Components:	Internals>Views>Desktop UI>Browser
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	1
Type:	Bug-Regression
Proj-MacViews

[MacViews-Browser] Regression: CMD-W closes the whole window instead just only a tab

Project Member Reported by meh...@chromium.org, Apr 21 2018

Issue description

Chrome Version: 68.0.3402.0
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) Enable MacViews-Browser in chrome://flags
(2) Open a New Window
(3) Open some New Tabs in this window
(4) Press CMD-W to close one tab

What is the expected result?
Just one tab should be closed.

What happens instead?
The whole window closes :-(

This is a recent regression in MacViews-Browser.

Chrome Version: 68.0.3402.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable MacViews-Browser in chrome://flags
(2) Open a New Window
(3) Open some New Tabs in this window
(4) Press CMD-W to close one tab

What is the expected result?
Just one tab should be closed.

What happens instead?
The whole window closes :-(

This is a recent regression in MacViews-Browser.

Chrome Version: Canary 68.0.3402.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable MacViews-Browser in chrome://flags
(2) Open a New Window
(3) Open some New Tabs in this window
(4) Press CMD-W to close one tab

What is the expected result?
Just one tab should be closed.

What happens instead?
The whole window closes :-(

This is a recent regression in MacViews-Browser (Canary).

Comment 1 by meh...@chromium.org, Apr 21 2018

Description: Show this description

Comment 2 by meh...@chromium.org, Apr 21 2018

Description: Show this description

Comment 3 by meh...@chromium.org, Apr 21 2018

Labels: -Needs-Bisect

Regression range: https://chromium.googlesource.com/chromium/src/+log/4f10bd80bd4f9fc7088ed0862a9e145fb8ecef34..9d6ee0d942abe7e89f831acd355a395c0a799233

ellyjones@: Maybe caused by your change from https://chromium-review.googlesource.com/c/chromium/src/+/1022530 ?

Thanks for looking into it.

Comment 4 by meh...@chromium.org, Apr 21 2018

Labels: -Type-Bug Type-Bug-Regression

Comment 5 by ellyjo...@chromium.org, Apr 23 2018

Status: Started (was: Untriaged)

Reverted the cause CL: <https://chromium-review.googlesource.com/c/chromium/src/+/1022530> -> <https://chromium-review.googlesource.com/c/chromium/src/+/1023192>

Comment 6 by meh...@chromium.org, Apr 23 2018

Thanks. Maybe helpful for your further fixing of the problem. If you open some tabs, the "unfocus" the Omnibox by clicking into the NTP and then press CMD-W, the problem does not appear. Here is a screencast.

	demo.mov 1.8 MB View Download

Comment 7 by ellyjo...@chromium.org, Apr 26 2018

Status: Fixed (was: Started)

►

Issue 835541 link

Issue metadata

[MacViews-Browser] Regression: CMD-W closes the whole window instead just only a tab

Issue description

Comment 1 by meh...@chromium.org, Apr 21 2018

Comment 1 Deleted

Comment 2 by meh...@chromium.org, Apr 21 2018

Comment 2 Deleted

Comment 3 by meh...@chromium.org, Apr 21 2018

Comment 3 Deleted

Comment 4 by meh...@chromium.org, Apr 21 2018

Comment 4 Deleted

Comment 5 by ellyjo...@chromium.org, Apr 23 2018

Comment 5 Deleted

Comment 6 by meh...@chromium.org, Apr 23 2018

Comment 6 Deleted

Comment 7 by ellyjo...@chromium.org, Apr 26 2018

Comment 7 Deleted

Sign in to add a comment