Issue metadata
Sign in to add a comment
|
19.8 KiB regression in resource_sizes (MonochromePublic.apk) at 552559:552559 |
||||||||||||||||||||
Issue descriptionCaused by “Enable skcms in Skia” Commit: a3796c2471b11c81c8b532d66388c1b5ea708c07 https://chromium-review.googlesource.com/c/chromium/src/+/1014327 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=480214 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Based on the graph: 19.8 KiB of native code. It looks to me that the size increase is expected. Feel free to close as “Won't Fix” unless you can see some way to reduce size. Please run: tools/binary_size/diagnose_bloat.py --cloud a3796c2471b11c81c8b532d66388c1b5ea708c07 to see details.
,
Apr 21 2018
Assigning to brianosman@google.com because this is the only CL in range: Enable skcms in Skia This switches Skia to use skcms for color space transformation. Layout test changes are expected, but should be minor. Change-Id: Id069e41c53fe69894a18f4e1aea0487f1ffe6cc2 Reviewed-on: https://chromium-review.googlesource.com/1014327 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#552559}
,
Apr 21 2018
Correct, this is intentional, and temporary. This CL switched color management from code path "A" to code path "B", but we're still linking in "A". Once we remove it (hopefully before this next milestone branches), we think there should be a net size win. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 21 2018