New issue
Advanced search Search tips

Issue 835509 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: CDM_9/ECKEncryptedMediaTest.MultipleCdmTypes/0



Sign in to add a comment

CDM_9/ECKEncryptedMediaTest.MultipleCdmTypes/0 is Flaky

Project Member Reported by Findit, Apr 21 2018

Issue description

Findit has detected a flake at test CDM_9/ECKEncryptedMediaTest.MultipleCdmTypes/0.

Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I84d79f7b9e63e80434139bedb6d5533baacf8ff0
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKBAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIFRlc3RzIChzYW5kYm94ZWQpLzQ1NjY3L2Jyb3dzZXJfdGVzdHMvUTBSTlh6a3ZSVU5MUlc1amNubHdkR1ZrVFdWa2FXRlVaWE4wTGsxMWJIUnBjR3hsUTJSdFZIbHdaWE12TUE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
 
Project Member

Comment 1 by Findit, Apr 21 2018

Findit identified the culprit r552436 with confidence 100.0% in the config "chromium.memory / Linux ASan Tests (sandboxed)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKBAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIFRlc3RzIChzYW5kYm94ZWQpLzQ1NjY3L2Jyb3dzZXJfdGVzdHMvUTBSTlh6a3ZSVU5MUlc1amNubHdkR1ZrVFdWa2FXRlVaWE4wTGsxMWJIUnBjR3hsUTJSdFZIbHdaWE12TUE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in beta.
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 2 by xhw...@chromium.org, Apr 21 2018

Cc: jrumm...@chromium.org
Components: Internals>Media>Encrypted
Owner: xhw...@chromium.org
Status: Started (was: Available)
I'll take a look.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad680907edd75864926df6f07e7485840aa6bffa

commit ad680907edd75864926df6f07e7485840aa6bffa
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Sat Apr 21 06:53:29 2018

media: Fix ECKEncryptedMediaTest.MultipleCdmTypes test

When session 2 crashes, it crashes on KeyStatusUpdate, which is after
resolving the update promise in Clear Key CDM. Due to IPC and async
calls, by the time the crash happens, the JS update promise could have
been resolved, or rejected due to the crash.

This CL use "finally" instead of "then" so that we will continue the
test regardlss whether the session update that causes the crash is
resolved or rejected.

Tbr: jrummell@chromium.org
Bug:  835509 
Change-Id: I380546b2f6cf29e60d082c79f913f46fad4eaf0b
Reviewed-on: https://chromium-review.googlesource.com/1023370
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552582}
[modify] https://crrev.com/ad680907edd75864926df6f07e7485840aa6bffa/media/test/data/multiple_cdm_types.html

Status: Fixed (was: Started)

Sign in to add a comment