Wrong indent with OOPIFs in the frame drop-down of console tab in DevTools |
||||||
Issue descriptionNot sure if we have a bug on file for this: (1) Start Chrome with --site-per-process (2) Go to http://csreis.github.io/tests/cross-site-iframe.html (3) Open DevTools, execute navFrame("http://csreis.github.io/tests/cross-site-iframe.html") to navigate the subframe to the same URL as the main frame. (4) Scroll the iframe and click "Go cross-site (simple page)" inside the iframe. This creates an A(A(B)) hierarchy. (5) Open the frame dropdown. What is the expected result? top frame1 (cross-site-iframe.html) frame1 (csreis.github.io) This is what I get without --site-per-process. What happens instead? top frame1 (cross-site-iframe.html) csreis.github.io So, the innermost frame isn't indented as it should be: it appears as a sibling of the middle "cross-site-iframe.html" frame, rather than its child. It also appears without the "frame1" name. (See screenshots.) Dmitry, can you please help triage?
,
Apr 21 2018
Yeah, this is definitely low priority, though it might be more of an issue for sites with lots of nested OOPIFs, as it makes it hard to figure out the frame hierarchy.
,
Apr 21 2018
,
Jun 15 2018
Looks like this has been fixed.
,
Jun 15 2018
I'm still seeing incorrect behavior on Mac Canary 69.0.3461.2 and also on Linux synced to r565529. Did a fix for this land very recently, or if not, would you mind taking another look?
,
Jun 15 2018
Ah sorry, I messed up the repro steps. I see it now, will fix.
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e803258b86e365b66e8ae3cb561efb0f03d64ab commit 6e803258b86e365b66e8ae3cb561efb0f03d64ab Author: Joel Einbinder <einbinder@chromium.org> Date: Sat Jun 16 05:21:45 2018 DevTools: Show OOPIFs at the correct depth in ConsoleContextSelector Bug: 835492 Change-Id: I172ab5075523f86eca85b4013dc0b77a82650dad Reviewed-on: https://chromium-review.googlesource.com/1103543 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#567875} [modify] https://crrev.com/6e803258b86e365b66e8ae3cb561efb0f03d64ab/third_party/blink/renderer/devtools/front_end/console/ConsoleContextSelector.js
,
Jun 18 2018
Thanks! I can confirm this is fixed on Mac Canary 69.0.3464.0. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by creis@chromium.org
, Apr 20 2018