New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835491 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

AutoFDO: Chrome: use profiles from Silvermont by default.

Project Member Reported by laszio@chromium.org, Apr 20 2018

Issue description

We would like to switch from benchmark trained profiles to profiles collected in the field. An unified profile from Silvermont machines will be used in the beginning.

Depending on the result experimental deployments, this may happen in R68.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c1272c7765e0f2dde8471e42a4f55a7ba073d257

commit c1272c7765e0f2dde8471e42a4f55a7ba073d257
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sun Jun 03 04:48:49 2018

chromeos-chrome: use autofdo profiles from silvermont by default

We would like to switch from benchmark trained profiles to profiles
collected in the field. An unified profile from Silvermont machines will
be used in the beginning.

TEST=cros tryjob squawks-release-tryjob snappy-release-tryjob
BUG= chromium:835491 

Change-Id: If201ececf845f46d8abd7855be62d4727ac13d3f
Reviewed-on: https://chromium-review.googlesource.com/1023050
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/c1272c7765e0f2dde8471e42a4f55a7ba073d257/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Labels: Merge-Request-68
We would like to put this change in the branch. 
We were waiting for data from 66 stable and it took a while so we missed the 68 branch point. 
But this change is pretty safe and has been tested on ToT without any issues.
It is just a change on the profiles. No other functional changes.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 5 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2018

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4633f94e1718c577abf8dd344ae50d70efa0e1cf

commit 4633f94e1718c577abf8dd344ae50d70efa0e1cf
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Jun 08 00:39:36 2018

chromeos-chrome: use autofdo profiles from silvermont by default

We would like to switch from benchmark trained profiles to profiles
collected in the field. An unified profile from Silvermont machines will
be used in the beginning.

TEST=cros tryjob squawks-release-tryjob snappy-release-tryjob
BUG= chromium:835491 

Change-Id: If201ececf845f46d8abd7855be62d4727ac13d3f
Reviewed-on: https://chromium-review.googlesource.com/1023050
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
(cherry picked from commit c1272c7765e0f2dde8471e42a4f55a7ba073d257)
Reviewed-on: https://chromium-review.googlesource.com/1091702
Commit-Queue: Luis Lozano <llozano@chromium.org>
Trybot-Ready: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/4633f94e1718c577abf8dd344ae50d70efa0e1cf/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 5 by sheriffbot@chromium.org, Jun 11 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-68
Status: Verified (was: Started)

Sign in to add a comment