2D UI - Keyboard is not dismissed before Exit VR dialog is displayed. |
|||||
Issue descriptionChrome Version: 68.0.3400.0 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Navigate to https://rsolomakhin.github.io/autofill/ (2) Entry VR Browsing (3) Trigger an Autofill dialog. (4) Click on the Autofill settings menu item. What is the expected result? The user is shown the "Exit VR" dialog. And the keyboard is not present. What happens instead? Keyboard is still present when the user is shown the "Exit VR" dialog. This is a regression from M67 behavior.
,
Apr 24 2018
,
Apr 25 2018
Doug, on my device, I've verified that the problem doesn't happen on 67. Therefore, this seems to be neither MVP, nor M-67-targeting. It should be an M-68 issue. Let me know if you disagree, otherwise, I'll adjust it.
,
Apr 25 2018
,
Apr 25 2018
This was caused by https://chromium-review.googlesource.com/c/chromium/src/+/1012989, which fixed a different issue. That change ensured that if we select an autofill choice, the native UI doesn't steal focus. The side effect of that was, clicking on "settings" also doesn't steal focus, and the input field keeps focus even when we show the "exit VR" prompt and hide content.
,
Apr 25 2018
On closer inspection, we show the keyboard simply based on whether we're editing UI input or web input. If we augment the web input case to be "editing web input and not showing a modal prompt", then we should be good to go.
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/958b96f30193d6b21de6cb82de7a882b3848aa2d commit 958b96f30193d6b21de6cb82de7a882b3848aa2d Author: Christopher Grant <cjgrant@chromium.org> Date: Mon Apr 30 16:36:56 2018 VR: Prevent keyboard from showing with exit-VR prompt If the exit-VR prompt shows while content is editing text, we should hide the keyboard. A side effect of this change is that, when the keyboard disappears, it notifies content that this has happened, and content loses focus. In the case of autofill settings, this means that if the user chooses autofill settings but dismisses the exit-VR prompt to return to their page, that the input field will no longer be focused for edit (and the keyboard won't be showing). In the 2D case, the keyboard is also hidden, but the cursor is still blinking in the field. Therefore, VR is not at parity with 2D, but this feels better than having the keyboard persist through VR modal dialogs. BUG= 835483 R=asimjour Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I753ec31273e2473a21ea5cd2c2dddf70c962f71a Reviewed-on: https://chromium-review.googlesource.com/1030873 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#554786} [modify] https://crrev.com/958b96f30193d6b21de6cb82de7a882b3848aa2d/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/958b96f30193d6b21de6cb82de7a882b3848aa2d/chrome/browser/vr/elements/content_element_unittest.cc [modify] https://crrev.com/958b96f30193d6b21de6cb82de7a882b3848aa2d/chrome/browser/vr/elements/keyboard.cc [modify] https://crrev.com/958b96f30193d6b21de6cb82de7a882b3848aa2d/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/958b96f30193d6b21de6cb82de7a882b3848aa2d/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/958b96f30193d6b21de6cb82de7a882b3848aa2d/chrome/browser/vr/ui_scene_creator.cc
,
May 1 2018
,
May 8 2018
Fix verified in build 67.0.3396.29 beta. Looks good. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dougman@chromium.org
, Apr 23 2018