Setup Printer Dialog fails if lpadmin crashes |
||
Issue descriptionWhat steps will reproduce the problem? (1) Start setting up a printer (2) Cause lpadmin to crash (break the seccomp filter) What is the expected result? Dialog reports that CUPS encountered an error What happens instead? No messages at all Behavior revealed by crbug.com/834521
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca91319fcf3be47ed958cb706defea91e4b17e93 commit ca91319fcf3be47ed958cb706defea91e4b17e93 Author: Sean Kau <skau@chromium.org> Date: Wed Apr 25 23:44:33 2018 Fix invalid call to on-manually-add-discovered-printer. on-manually-add-discovered-printer was being called with invalid parameters. Refactor so it's easier to call properly and fix the bad callsite. Observed behavior was that the setup dialog would close without any messaging. User is prompted for a PPD now. Bug: 835476 Change-Id: I85ae96cf1f9638098cd819fccb47b30e16274a58 Reviewed-on: https://chromium-review.googlesource.com/1023040 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#553827} [modify] https://crrev.com/ca91319fcf3be47ed958cb706defea91e4b17e93/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc [modify] https://crrev.com/ca91319fcf3be47ed958cb706defea91e4b17e93/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
,
Apr 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by skau@chromium.org
, Apr 24 2018