Cleanup actions.xml for in-product help |
||
Issue descriptionChrome Version: (copy from chrome://version) OS: All What steps will reproduce the problem? (1) Follow steps for adding a new in-product help: https://chromium.googlesource.com/chromium/src/+/master/components/feature_engagement/README.md#Configuring-UMA What is the expected result? I add one more line with my new in-product help feature in actions.xml. What happens instead? I have to copy-paste 6 different actions, which is error prone and should be unnecessary. Notes: When https://chromium-review.googlesource.com/c/chromium/src/+/1015293/ lands, we should be able to do that. We should then update the documentation. Also, we should consider filing a bug to moving the suffix-list to a separate file with its own OWNERS, etc. The core work to fix this bug is to clean up all the old IPH actions, and consolidate them to using the new framework.
,
Jul 17
asvitkine: Should the action suffixes list be moved to a separate file and OWNERS policy, or should it be kept where it is right now?
,
Jul 18
I think the changes to these is low-traffic enough that it's fine to keep as-is. Moving them out adds complexity which is not warranted given the low traffic, imo.
,
Jul 18
SGTM! |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 16