test_push is broken because 'atest stable_version' no longer exists |
||
Issue description
Invalid topic stable_version
Traceback (most recent call last):
File "./site_utils/test_push.py", line 721, in <module>
main()
File "./site_utils/test_push.py", line 708, in main
arguments = parse_arguments()
File "./site_utils/test_push.py", line 275, in parse_arguments
arguments.build = get_default_build(arguments.board, arguments.web)
File "./site_utils/test_push.py", line 217, in get_default_build
result = subprocess.check_output(cmd, shell=True).strip()
File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '/usr/local/autotest/cli/atest stable_version list --board=gandof -w chromeos-staging-master2.hot' returned non-zero exit status 1
,
Apr 20 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/df588551e4a588450e5d8dad8ea653700b1819be commit df588551e4a588450e5d8dad8ea653700b1819be Author: Richard Barnette <jrbarnette@chromium.org> Date: Fri Apr 20 22:42:39 2018 Revert "[autotest] Delete `atest stable_version`" This reverts commit 5bd9071c5f2306ec19ca42c965dbf2eae1c41677. Breaks push_to_prod BUG= chromium:835447 Change-Id: I54567319174cfce25925f26956a4b3fedf8d2e11 Reviewed-on: https://chromium-review.googlesource.com/1022772 Reviewed-by: Richard Barnette <jrbarnette@google.com> Tested-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/df588551e4a588450e5d8dad8ea653700b1819be/cli/topic_common.py [add] https://crrev.com/df588551e4a588450e5d8dad8ea653700b1819be/cli/stable_version.py [modify] https://crrev.com/df588551e4a588450e5d8dad8ea653700b1819be/cli/atest_unittest.py
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2af822156daf58cd5d842dda9118e981badd2d5c commit 2af822156daf58cd5d842dda9118e981badd2d5c Author: Richard Barnette <jrbarnette@chromium.org> Date: Wed Apr 25 21:40:49 2018 [autotest] Fix test_push to find its test build properly The test_push script depended on `atest stable_version`, which needs to be deleted. Fix the dependency to use a more stable interface. BUG= chromium:835447 TEST=unit tests; run a stubbed script on the test instance Change-Id: I537cc7e056ba9feb6e5d6a284332d5f41b64baa1 Reviewed-on: https://chromium-review.googlesource.com/1022749 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Congbin Guo <guocb@chromium.org> [modify] https://crrev.com/2af822156daf58cd5d842dda9118e981badd2d5c/site_utils/test_push.py [modify] https://crrev.com/2af822156daf58cd5d842dda9118e981badd2d5c/site_utils/test_push_unittest.py
,
Apr 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aeb79663c57d48e7df60080797caf303d25cbe31 commit aeb79663c57d48e7df60080797caf303d25cbe31 Author: Richard Barnette <jrbarnette@chromium.org> Date: Sun Apr 29 04:26:31 2018 [autotest] Reland "Delete `atest stable_version`" The `atest stable_version` command has been replaced with the `stable_version` command, and the last known client has been removed. So, delete the obsolete code. BUG= chromium:835447 TEST=run `atest stable_version`, see it fail. Change-Id: I0af83145b56dc7ab134ef72d4102d2e7ccbf2016 Reviewed-on: https://chromium-review.googlesource.com/1033503 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/aeb79663c57d48e7df60080797caf303d25cbe31/cli/topic_common.py [delete] https://crrev.com/23ce17357baaca2047f3b8a4ae74e6d275b29280/cli/stable_version.py [modify] https://crrev.com/aeb79663c57d48e7df60080797caf303d25cbe31/cli/atest_unittest.py
,
May 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by pprabhu@chromium.org
, Apr 20 2018