New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 835446 link

Starred by 3 users
Status: Fixed
Owner:
rsesek@chromium.org
Closed: May 2018
Cc:
█ roc...@chromium.org
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Use namespace.mojom.Interface syntax in manifests, instead of namespace::mojom::Interface

Project Member Reported by rsesek@chromium.org, Apr 20 2018 
Per the title, we should change the Mojo manifest syntax to match the .mojom syntax for referencing namespaced interfaces.

Before, you'd write "namespace::mojom::Interface" in a capability spec in a manifest, and after it should be "namespace.mojom.Interface".

This was discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/zzigTT7EPW0

Comment 1 by dcheng@chromium.org, Apr 20 2018

Cc: dcheng@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/583d4851014f69958dc4c4960b5fbe6202bc4a8c

commit 583d4851014f69958dc4c4960b5fbe6202bc4a8c
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue May 15 21:37:20 2018

Change mojo manifest interface syntax from foo::mojom::Bar to foo.mojom.Bar.

This updates the bindings generators and hard-coded interface names in
tests and the service_manager.

The remainder of the CL was generated by:

for f in $(find . -name '*.json' -not \( -path './out/*' -o -path './third_party/*' -o -path '*.xcassets/*' \)); do
  grep interface_provider_spec "./$f" >/dev/null && gsed -i s/::/./g "$f";
done

Tbr: jam@chromium.org
Bug:  835446 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0bb22615b9c66824c6f95da66e3d7016809d63c7
Reviewed-on: https://chromium-review.googlesource.com/1026419
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558841}
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/android_webview/browser/aw_browser_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/android_webview/browser/aw_renderer_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/android_webview/browser/aw_utility_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ash/components/autoclick/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ash/components/quick_launch/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ash/components/touch_hud/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ash/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/app/chrome_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/app/chrome_renderer_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/browser/chrome_content_gpu_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/browser/chrome_content_renderer_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/browser/chrome_content_utility_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/browser/chromeos/prefs/ash_pref_connector_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/services/file_util/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/services/media_gallery_util/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/services/printing/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/services/removable_storage_writer/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/services/util_win/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/services/wifi_util_win/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chrome/utility/importer/profile_import_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chromecast/browser/cast_content_browser_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chromeos/services/assistant/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chromeos/services/assistant/unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chromeos/services/device_sync/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/chromeos/services/multidevice_setup/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/nacl/broker/nacl_broker_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/nacl/loader/nacl_loader_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/printing/service/pdf_compositor_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/printing/service/pdf_compositor_service_unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/services/filesystem/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/services/font/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/services/heap_profiling/heap_profiling_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/services/leveldb/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/services/patch/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/components/services/unzip/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/browser/frame_host/render_frame_host_impl_browsertest.cc
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/public/app/mojo/content_gpu_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/public/app/mojo/content_packaged_services_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/public/app/mojo/content_plugin_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/public/app/mojo/content_utility_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/shell/browser/content_shell_browser_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/shell/browser/content_shell_gpu_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/shell/browser/content_shell_renderer_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/shell/browser/content_shell_utility_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/content/test/unittests_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/headless/lib/renderer/headless_renderer_manifest_overlay.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ios/web/public/app/mojo/web_browser_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ios/web/public/app/mojo/web_packaged_services_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/ios/web/webui/mojo_facade_unittest.mm
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mash/catalog_viewer/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mash/example/views_examples/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mash/example/window_type_launcher/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mash/task_viewer/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/media/mojo/services/cdm_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/media/mojo/services/cdm_service_unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/media/mojo/services/media_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mojo/android/javatests/src/org/chromium/mojo/bindings/InterfacesTest.java
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mojo/public/cpp/bindings/tests/constant_unittest.cc
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/audio/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/audio/test/service_unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/catalog/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/data_decoder/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/device/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/device/unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/file/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/identity/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/identity/unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/metrics/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/network/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/network/test/service_unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/preferences/local_state_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/preferences/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/preferences/unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/proxy_resolver/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/resource_coordinator/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/background/tests/test_service_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/service_manager.cc
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/connect/connect_test_app_a_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/connect/connect_test_app_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/connect/connect_test_class_app_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/connect/connect_test_package_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/connect/connect_unittests_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/lifecycle/app_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/lifecycle/exe_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/lifecycle/package_app_a_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/lifecycle/package_app_b_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/lifecycle/package_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/lifecycle/parent_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/service_manager/embedder_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/service_manager/service_manager_unittest_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/shutdown/shutdown_client_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/service_manager/tests/shutdown/shutdown_service_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/shape_detection/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/test/echo/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/test/user_id/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/tracing/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/ui/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/ui/test_ws/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/ui/ws/test_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/ui/ws2/test_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/video_capture/service_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/viz/manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/services/viz/test_manifest.json
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/chooser_service.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/device.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/device_manager.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/mojo_layouttest_test.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/sensor.mojom.js
[modify] https://crrev.com/583d4851014f69958dc4c4960b5fbe6202bc4a8c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/sensor_provider.mojom.js
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f77782daf6b344f82b2ac0406fbad56aea830688

commit f77782daf6b344f82b2ac0406fbad56aea830688
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu May 17 17:57:33 2018

Finish converting mojo interface syntax from foo::mojom::Bar to foo.mojom.Bar.

This updates documentation and comments. It also fixes one instance of
code in media_router_bindings.js.

Tbr: markdown change
Bug:  835446 
Change-Id: Iae247c318cf9547d4d536a1a04c0f7a9cf65eb14
Reviewed-on: https://chromium-review.googlesource.com/1062345
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559600}
[modify] https://crrev.com/f77782daf6b344f82b2ac0406fbad56aea830688/chrome/renderer/resources/extensions/media_router_bindings.js
[modify] https://crrev.com/f77782daf6b344f82b2ac0406fbad56aea830688/components/spellcheck/common/spellcheck.mojom
[modify] https://crrev.com/f77782daf6b344f82b2ac0406fbad56aea830688/content/browser/websockets/README.md
[modify] https://crrev.com/f77782daf6b344f82b2ac0406fbad56aea830688/ipc/README.md
[modify] https://crrev.com/f77782daf6b344f82b2ac0406fbad56aea830688/third_party/blink/renderer/modules/websockets/README.md
[modify] https://crrev.com/f77782daf6b344f82b2ac0406fbad56aea830688/tools/metrics/histograms/enums.xml

Comment 4 by rsesek@chromium.org, May 17 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment