New issue
Advanced search Search tips

Issue 835437 link

Starred by 1 user
Status: Fixed
Owner:
groeck@chromium.org
Closed: Apr 2018
Cc:
vapier@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros-kernel2 get_build_arch() is broken for amd64 builds

Project Member Reported by groeck@chromium.org, Apr 20 2018 
When trying to build an image with the upstream kernel, I noticed that images for Intel boards always ended up using x86_defconfig instead of x86_64_defconfig.
The reason turns out to be the value of the ARCH variable, which is "amd64". This is not explicitly handled in get_build_arch(); it defaults to the output of tc-arch-kernel. This function returns "x86", not the expected "x86_64".
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6e03f301db5b0fb219e302a3bb1449f597554e84

commit 6e03f301db5b0fb219e302a3bb1449f597554e84
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue Apr 24 13:22:19 2018

cros-kernel2: Handle ARCH value of "amd64"

If ARCH is "amd64", get_build_arch() should return "x86_64", not "x86".

Also, since we are at it, document get_build_arch().

BUG= chromium:835437 
TEST=trybot with various platforms

Change-Id: Ie0e44f394f4ef8d741ff8812e635f9ae04d4395d
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1022830
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6e03f301db5b0fb219e302a3bb1449f597554e84/eclass/cros-kernel2.eclass

Comment 2 by groeck@chromium.org, Apr 24 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment