Don't sent RLZ first-search ping if another user already did |
||||||
Issue descriptionThis is to fix a critical use case overlooked in the original feature implementation for crbug.com/820783. Fixed on ToT: https://chromium-review.googlesource.com/c/chromium/src/+/1017962
,
Apr 20 2018
,
Apr 21 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2018
Roger, can you go ahead and merge this to M67? This one is critical.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29cddb9a8cf42f3231d2eab6a372bf4758432b2d commit 29cddb9a8cf42f3231d2eab6a372bf4758432b2d Author: Roger Tawa <rogerta@chromium.org> Date: Mon Apr 23 14:24:39 2018 Change minimum RLZ ping delay on chromeos to 60sec. Bug: 820783, 835430 Change-Id: If60b92464261fbf6523153f9cab9bba5bbf61dcd Reviewed-on: https://chromium-review.googlesource.com/1022513 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552460}(cherry picked from commit a7523d1f37db7dbd6cb2bcb6dbe0487deb72b462) Reviewed-on: https://chromium-review.googlesource.com/1024091 Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#206} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/29cddb9a8cf42f3231d2eab6a372bf4758432b2d/components/rlz/rlz_tracker.cc
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0717323ac378103b0a730ca22c9031cdac8c4c97 commit 0717323ac378103b0a730ca22c9031cdac8c4c97 Author: Roger Tawa <rogerta@chromium.org> Date: Mon Apr 23 15:14:36 2018 Don't sent RLZ first-search ping if another user already did. On chromeos, if one user performs a search and logs out before the RLZ ping is sent, and then another user logs in, performs a search and send the ping, make the sure the first user does not also send a ping. Bug: 820783, 835430 Change-Id: Ic3ce70bada8734e260e066d4700b3d4fa7eda887 Reviewed-on: https://chromium-review.googlesource.com/1017962 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552133}(cherry picked from commit ade5154582ace9872f3acda39071492eaf7d0820) Reviewed-on: https://chromium-review.googlesource.com/1024111 Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#211} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/0717323ac378103b0a730ca22c9031cdac8c4c97/rlz/chromeos/lib/rlz_value_store_chromeos.cc [modify] https://crrev.com/0717323ac378103b0a730ca22c9031cdac8c4c97/rlz/lib/rlz_lib_test.cc
,
Apr 25 2018
Verified this is working on ChromeOS 10575.16.0, 67.0.3396.19 dev-channel
,
Oct 12
,
Oct 18
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by stephenlin@chromium.org
, Apr 20 2018