New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835430 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 820783



Sign in to add a comment

Don't sent RLZ first-search ping if another user already did

Project Member Reported by stephenlin@chromium.org, Apr 20 2018

Issue description

This is to fix a critical use case overlooked in the original feature implementation for crbug.com/820783.

Fixed on ToT: https://chromium-review.googlesource.com/c/chromium/src/+/1017962


 
Pasted from crbug.com/820783


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ade5154582ace9872f3acda39071492eaf7d0820

commit ade5154582ace9872f3acda39071492eaf7d0820
Author: Roger Tawa <rogerta@chromium.org>
Date: Thu Apr 19 20:01:43 2018

Don't sent RLZ first-search ping if another user already did.

On chromeos, if one user performs a search and logs out before the
RLZ ping is sent, and then another user logs in, performs a search and
send the ping, make the sure the first user does not also send a ping.

Bug: 820783
Change-Id: Ic3ce70bada8734e260e066d4700b3d4fa7eda887
Reviewed-on: https://chromium-review.googlesource.com/1017962
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552133}
[modify] https://crrev.com/ade5154582ace9872f3acda39071492eaf7d0820/rlz/chromeos/lib/rlz_value_store_chromeos.cc
[modify] https://crrev.com/ade5154582ace9872f3acda39071492eaf7d0820/rlz/lib/rlz_lib_test.cc
Components: -UI
Labels: OS-Chrome
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 21 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Roger, can you go ahead and merge this to M67? This one is critical.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 23 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29cddb9a8cf42f3231d2eab6a372bf4758432b2d

commit 29cddb9a8cf42f3231d2eab6a372bf4758432b2d
Author: Roger Tawa <rogerta@chromium.org>
Date: Mon Apr 23 14:24:39 2018

Change minimum RLZ ping delay on chromeos to 60sec.

Bug: 820783,  835430 
Change-Id: If60b92464261fbf6523153f9cab9bba5bbf61dcd
Reviewed-on: https://chromium-review.googlesource.com/1022513
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552460}(cherry picked from commit a7523d1f37db7dbd6cb2bcb6dbe0487deb72b462)
Reviewed-on: https://chromium-review.googlesource.com/1024091
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#206}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/29cddb9a8cf42f3231d2eab6a372bf4758432b2d/components/rlz/rlz_tracker.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0717323ac378103b0a730ca22c9031cdac8c4c97

commit 0717323ac378103b0a730ca22c9031cdac8c4c97
Author: Roger Tawa <rogerta@chromium.org>
Date: Mon Apr 23 15:14:36 2018

Don't sent RLZ first-search ping if another user already did.

On chromeos, if one user performs a search and logs out before the
RLZ ping is sent, and then another user logs in, performs a search and
send the ping, make the sure the first user does not also send a ping.

Bug: 820783,  835430 
Change-Id: Ic3ce70bada8734e260e066d4700b3d4fa7eda887
Reviewed-on: https://chromium-review.googlesource.com/1017962
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552133}(cherry picked from commit ade5154582ace9872f3acda39071492eaf7d0820)
Reviewed-on: https://chromium-review.googlesource.com/1024111
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#211}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/0717323ac378103b0a730ca22c9031cdac8c4c97/rlz/chromeos/lib/rlz_value_store_chromeos.cc
[modify] https://crrev.com/0717323ac378103b0a730ca22c9031cdac8c4c97/rlz/lib/rlz_lib_test.cc

Verified this is working on ChromeOS 10575.16.0, 67.0.3396.19 dev-channel
Components: Internals>Metrics>RLZ
Status: Verified (was: Assigned)

Sign in to add a comment