Issue metadata
Sign in to add a comment
|
Make BrowsingDataChannelIDHelper work with the network service |
||||||||||||||||||||||||||
Issue descriptionBrowsingDataChannelIDHelper lives in chrome/, an expects direct access to the SSLConfigService. With the advent of the network service, this will no longer be possible. Channel ID is deprecated, but the network service project probably shouldn't block on a full removal of Channel ID code from Chromium.
,
Nov 7
Is channel ID gone? BrowsingDataChannelIDHelper still exists, the ChannelIDStore is still in use, etc.
,
Nov 7
I think it's disabled but the code is still being unwound? Issue #875053. Not sure. I vaguely recall you all closing a different network service + Channel ID bug on grounds that it was effectively gone, but I could be making this up.
,
Nov 8
David is right - https://chromium.googlesource.com/chromium/src.git/+/ca145100feb1259b958f63c6a3311ba41df0f3b9 (linked to in issue #875053) permanently disables Channel ID. I'm still working on unwinding the code. Is the existence of BrowsingDataChannelIDHelper blocking servicification? If so, I can put it next on the chopping block.
,
Nov 8
Awesome! I don't think it is - it doesn't crash if we use it, at least, though it is a dependency on the bogus in-process URLRequestContextGetter existing - there are a bunch of other dependencies on that, though, so I don't think there's any rush here. I'll go ahead and merge this with issue 875053. Thanks, Nick! |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by davidben@google.com
, Nov 7Components: Internals>Services>Network