New issue
Advanced search Search tips

Issue 835405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 812974



Sign in to add a comment

Remove the posix source exclusion filter

Project Member Reported by fdegans@chromium.org, Apr 20 2018

Issue description

This is a tracking bug to remove the posix source exclusion filter.
This will allow us to separate the Fuchsia and Posix implementations more cleanly.
 
The exclusion filters are defined in BUILDCONFIG.gn.
https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?l=405
These are mostly a remnant from the gyp migration, they automagically exclude source files based on a pattern.

As part of the Fuchsia switch to not being treated as a posix platform by default, we need to do changes in a lot of source sets. It is a smaller and cleaner change to remove this exclusion filter.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d89f77e7268c8411d1e7e42191fb3b349b95f297

commit d89f77e7268c8411d1e7e42191fb3b349b95f297
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Apr 20 20:45:28 2018

Clean up the posix source files in remoting/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: I366702366aa40eb6fbfb4d4477db4afdc88c6c3e
Reviewed-on: https://chromium-review.googlesource.com/1022313
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552462}
[modify] https://crrev.com/d89f77e7268c8411d1e7e42191fb3b349b95f297/remoting/host/BUILD.gn
[modify] https://crrev.com/d89f77e7268c8411d1e7e42191fb3b349b95f297/remoting/host/security_key/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcd46ecd63438dacaafe8e0b2b6a0823f4c8d3c

commit edcd46ecd63438dacaafe8e0b2b6a0823f4c8d3c
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Apr 20 21:18:50 2018

Clean up the posix source files in base/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: I2159ba20f38c901754e19add2ae4952000f43455
Reviewed-on: https://chromium-review.googlesource.com/1022127
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552472}
[modify] https://crrev.com/edcd46ecd63438dacaafe8e0b2b6a0823f4c8d3c/base/BUILD.gn
[modify] https://crrev.com/edcd46ecd63438dacaafe8e0b2b6a0823f4c8d3c/base/test/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c15a51aaa066da957f4a0a13b2962247fbd21d80

commit c15a51aaa066da957f4a0a13b2962247fbd21d80
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Apr 20 21:19:00 2018

Clean up the posix source files in rlz/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: I6f9ca7dda2679bf7b4b1bf896ab734b35e5a3f3b
Reviewed-on: https://chromium-review.googlesource.com/1022330
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552473}
[modify] https://crrev.com/c15a51aaa066da957f4a0a13b2962247fbd21d80/rlz/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab6b077ba985fe6d6049c51b35a8af870a551db

commit 0ab6b077ba985fe6d6049c51b35a8af870a551db
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Apr 20 21:32:58 2018

Clean up the posix source files in net/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: Ic1cff01e66cedbe0542b86d823d8a1df4bbe69c9
Reviewed-on: https://chromium-review.googlesource.com/1022312
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552479}
[modify] https://crrev.com/0ab6b077ba985fe6d6049c51b35a8af870a551db/net/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fdec6944a0dead05a86bfb54e42c092d6dcad5b

commit 3fdec6944a0dead05a86bfb54e42c092d6dcad5b
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Apr 20 21:53:59 2018

Clean up the posix source files in ipc/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: I62942475e2e3b14c1fb94623213ad9b36307b5a0
Reviewed-on: https://chromium-review.googlesource.com/1022310
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552486}
[modify] https://crrev.com/3fdec6944a0dead05a86bfb54e42c092d6dcad5b/ipc/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd5877f0710b75fdb1eede3f6e954aafc2b2ea88

commit bd5877f0710b75fdb1eede3f6e954aafc2b2ea88
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Fri Apr 20 23:52:29 2018

Clean up the posix source files in ui/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: I69e6b3ba30daafc57ab06c664f0166ba537dbc05
Reviewed-on: https://chromium-review.googlesource.com/1022315
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552523}
[modify] https://crrev.com/bd5877f0710b75fdb1eede3f6e954aafc2b2ea88/ui/base/BUILD.gn
[modify] https://crrev.com/bd5877f0710b75fdb1eede3f6e954aafc2b2ea88/ui/events/BUILD.gn
[modify] https://crrev.com/bd5877f0710b75fdb1eede3f6e954aafc2b2ea88/ui/surface/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/366a4d4fea7f89eda89c9621547fe07b7a7ac597

commit 366a4d4fea7f89eda89c9621547fe07b7a7ac597
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon Apr 23 19:04:12 2018

Clean up the posix source files in mojo/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: Ica1adbaab55c9cc64edd4a1d4dc6b57ddae8f967
Reviewed-on: https://chromium-review.googlesource.com/1022189
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552781}
[modify] https://crrev.com/366a4d4fea7f89eda89c9621547fe07b7a7ac597/mojo/edk/test/BUILD.gn

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa5eccecc0ee8daee613c9b60ce3c310eb33ecda

commit aa5eccecc0ee8daee613c9b60ce3c310eb33ecda
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon Apr 23 23:00:30 2018

Clean up the posix source files in device/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: I80edca54856078335d6e09303738a63bed451d18
Reviewed-on: https://chromium-review.googlesource.com/1022129
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552878}
[modify] https://crrev.com/aa5eccecc0ee8daee613c9b60ce3c310eb33ecda/device/BUILD.gn
[modify] https://crrev.com/aa5eccecc0ee8daee613c9b60ce3c310eb33ecda/device/serial/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35f496a65fd3f97730dd0b55107327d8308f8595

commit 35f496a65fd3f97730dd0b55107327d8308f8595
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Apr 24 00:26:31 2018

Clean up the posix source files in components/

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug:  835405 
Change-Id: If1cb03849e1d18149cce178c45f44e7f764fea72
Reviewed-on: https://chromium-review.googlesource.com/1022186
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552922}
[modify] https://crrev.com/35f496a65fd3f97730dd0b55107327d8308f8595/components/download/internal/common/BUILD.gn
[modify] https://crrev.com/35f496a65fd3f97730dd0b55107327d8308f8595/components/os_crypt/BUILD.gn
[modify] https://crrev.com/35f496a65fd3f97730dd0b55107327d8308f8595/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/35f496a65fd3f97730dd0b55107327d8308f8595/components/services/heap_profiling/BUILD.gn
[modify] https://crrev.com/35f496a65fd3f97730dd0b55107327d8308f8595/components/services/heap_profiling/public/cpp/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1550bd3f6d3c425573dc7009d327bba738b4fa88

commit 1550bd3f6d3c425573dc7009d327bba738b4fa88
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Apr 24 23:10:17 2018

Remove the posix sources exclusion filter

Bug:  835405 
Change-Id: I0dc49d7d8dd4c5cb05e93007c020bca4cf7830b0
Reviewed-on: https://chromium-review.googlesource.com/1013061
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553344}
[modify] https://crrev.com/1550bd3f6d3c425573dc7009d327bba738b4fa88/build/config/BUILDCONFIG.gn

Status: Fixed (was: Assigned)
Cautiously closing as fixed, the removal seems to have stuck.

Sign in to add a comment