New issue
Advanced search Search tips

Issue 835400 link

Starred by 0 users
Status: Verified
Owner:
eugene...@chromium.org
Closed: Apr 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Address bar and content area mismatch when navigating to invalid data urls

Project Member Reported by srikanthg@chromium.org, Apr 20 2018 
App Version: 67.0.3396.13 beta
iOS Version: 11.4, 10.3.3
Device: iPhoneX, iPhone7Plus
URL: any

Steps to reproduce:
  1. Launch Google Chrome
  2. Navigate to techmeme.com
  3. Navigate to data:exe on the same tab

Observed results: Address bar is updated but page still shows the contents of previous page

Expected results: Blank page should be displayed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NO, Safari: NO
Bug reproducible on current stable build (App Version, iOS Version): M66 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M67 Yes

Link to video/image: https://drive.google.com/file/d/1OYy68FHClwaXb-2TkRDhh1z2RIUkWmhy/view

Comment 1 by eugene...@chromium.org, Apr 20 2018

Cc: -eugene...@chromium.org
Labels: -Restrict-View-Google ReleaseBlock-Stable M-67
Owner: eugene...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f788ec3799aa5888265090ee4e2e191b56a71983

commit f788ec3799aa5888265090ee4e2e191b56a71983
Author: Eugene But <eugenebut@google.com>
Date: Tue Apr 24 21:31:42 2018

Always discard pending item if response can not be displayed.

This change will keep web content area in sync with displayed URL.
Previously displayed pending URL (like data:exe) did not match web
content.

Bug:  835400 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6417df266dd54b8aad0790b52bc2c576ead52d48
Reviewed-on: https://chromium-review.googlesource.com/1022743
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553284}
[modify] https://crrev.com/f788ec3799aa5888265090ee4e2e191b56a71983/ios/web/web_state/ui/crw_web_controller.mm

Comment 3 by eugene...@chromium.org, Apr 24 2018

Labels: Merge-Request-67
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e83752b1e6f665221d5d247a34acb53643e5f933

commit e83752b1e6f665221d5d247a34acb53643e5f933
Author: Eugene But <eugenebut@google.com>
Date: Wed Apr 25 22:27:16 2018

Always discard pending item if response can not be displayed.

This change will keep web content area in sync with displayed URL.
Previously displayed pending URL (like data:exe) did not match web
content.

TBR=eugenebut@google.com

(cherry picked from commit f788ec3799aa5888265090ee4e2e191b56a71983)

Bug:  835400 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6417df266dd54b8aad0790b52bc2c576ead52d48
Reviewed-on: https://chromium-review.googlesource.com/1022743
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553284}
Reviewed-on: https://chromium-review.googlesource.com/1028994
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#314}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/e83752b1e6f665221d5d247a34acb53643e5f933/ios/web/web_state/ui/crw_web_controller.mm

Comment 6 by vbarig...@chromium.org, May 2 2018

Status: Verified (was: Fixed)
Verified on chrome beta version 67.0.3396.31 on iPhone 8 plus with iOS 11.2.6 following  steps mentioned in comment #0.  Address bar is not updated and previous page content is displayed.  Looks good.
►

Sign in to add a comment